Internal 8.0 PRs attempt to run publishing

[mmitche]

Internal 8.0 PRs attempt to run publishing and validation stages. They may be set up as official builds

[Tanya-Solyanik]

@mmitche - how do I reproduce this privately or test the fix?

[mmitche]

Make a PR against the internal/release/8.0 brnach in AzDO.

[Tanya-Solyanik]

I created 2 PRs against internal/release/8.0
one PR to reproduce the problem, and see the publishing stage fail - https://dev.azure.com/dnceng/internal/_git/dotnet-windowsdesktop/pullrequest/47333
result: ##[error]Artifact ReleaseConfigs not found for build 2635424. Please ensure you have published artifacts in any previous phases of the current build.

Second PR with the official build variable removed - https://dev.azure.com/dnceng/internal/_git/dotnet-windowsdesktop/pullrequest/47344 - fails on the same step.

[Tanya-Solyanik]

@mmitche - I don't see any difference between the PR build with OfficialBuildId set in the yml script and the one where it's not set.

[mmitche]

@Tanya-Solyanik The issue is that the Publish build assets and post build stages should be conditionalized out in PRs. But, it looks like it might be simpler altogether. There is already a separate PR pipeline: https://dev.azure.com/dnceng/internal/_build?definitionId=1352. We should disable the official build for PRs, and enable that. I'll do that.

[Tanya-Solyanik]

We should disable the official build for PRs - should I merge this pr?

[mmitche]

yes, that PR is still correct.