Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage merger should not fail when additional fields are present #1

Open
DreierF opened this issue Aug 27, 2018 · 2 comments
Open

Comments

@DreierF
Copy link

DreierF commented Aug 27, 2018

Since we use an additional field inside the closure coverage format to document which test produced the coverage contained in the file, the coverage merger complains about the file having a wrong format. IMHO it should only fail if some required fields are missing, but additional ones should be ok or only produce a warning.

Error: Wrong format of coverage in .../coverage-856910907.json
at ClosureCoverageMerger.error (closure-coverage-merger.js:107:9)
at ClosureCoverageMerger.checkCoverage (coverage-merger.js:54:9)
at inputFileNames.forEach.fileName (coverage-merger.js:45:9)
at Array.forEach (<anonymous>)
at ClosureCoverageMerger.parseFiles (coverage-merger.js:43:18)
at ClosureCoverageMerger.mergeCoverage (coverage-merger.js:37:8)
at readArgumentsAndMergeCoverage (closure-coverage-merger/lib/index.js:47:9)
at Object.<anonymous> (closure-coverage-merger/lib/index.js:50:1)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
@dpagano
Copy link
Owner

dpagano commented Aug 31, 2018

I agree. Do you want to make the changes?

@DreierF
Copy link
Author

DreierF commented Sep 1, 2018

I'll try it after vacation 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants