Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search improvement ? #54

Open
jkanche opened this issue May 25, 2021 · 1 comment
Open

Search improvement ? #54

jkanche opened this issue May 25, 2021 · 1 comment

Comments

@jkanche
Copy link

jkanche commented May 25, 2021

Hello @dpryan79, I was wondering if this could potentially speed up the library.

During the walkRTreeNodes process, the library seems to iterate through all children to figure out if a block overlaps with the current region or not either in overlapsLeaf or overlapsNonLeaf

Instead can this use a binary search approach to find an overlapping block and search the neighborhood for all overlaps ? I'm trying to think of a scenario why this would fail but let me know if you have any thoughts on this

@dpryan79
Copy link
Owner

@jkanche I expect that would work, I think at the time I expected the performance benefit to be relatively small, since there are usually only a smallish number of child nodes to iterate over. Perhaps the improvement is more substantial though. If you're interested in putting together a PR that implements that I'd be quite happy to give it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants