Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks and syntax highlighting no longer works #45

Open
pakyrs opened this issue Jun 12, 2024 · 6 comments
Open

Code blocks and syntax highlighting no longer works #45

pakyrs opened this issue Jun 12, 2024 · 6 comments
Assignees

Comments

@pakyrs
Copy link

pakyrs commented Jun 12, 2024

I believe this happened before but all the code blocks are now no longer showing and the syntax highlighting is also not functioning properly.

2024-06-12_08-41

@Chrismettal
Copy link
Collaborator

Can you share your exact string?

Code block highlighting is working generally, but it might be missing highlighting for shell scripts (You can see "vim" below being highlighted at least)

Other themes I'm flicking through also don't do much with the install commands specifically.

image

@pakyrs
Copy link
Author

pakyrs commented Jun 13, 2024

Indeed the simple shell commands I have don't pay any justice, however not even the comments are commented out.

This was working absolutely as expected until the theme updated.

As you can see the highlighting works, but commented lines are not grey or less obvious. Also weirdly the code block is the same color as the background of the page, this only happen in this theme, and I don't have any weird CSS going on.

To further troubleshoot I spun up a Fedora VM and installed the latest Obsidian Flatpak and It's the same there, with 0 plugin, so I assume the theme just changed recently for the worst.

Dracula Official
2024-06-13_21-18

Dracula Gemini
2024-06-13_21-21

Thanks for helping anyway.

@pakyrs
Copy link
Author

pakyrs commented Jun 13, 2024

Ok i found the pickle, I don't know CSS, but the version pushed on Obsidian theme store is 1.1.0 which should be the same as the git repo, however the code for theme.css differ.

Therefore 1.0.7 was my original which had no issue, I was able to grab this from my ZFS snapshots and everything started to work again.

Then comparing 1.1.0 from git vs 1.1.0 from the obsidian store they are different. I downloaded the git version and it works fine, hence the issue is in the code pushed to Obsidian then.

@Chrismettal
Copy link
Collaborator

So 1.1.0 straight from the repo works for you?

There's gonna be a small rework to code theming soon (#39) so a new version will be pushed to the store afterwards.

@Chrismettal Chrismettal self-assigned this Jun 15, 2024
@pakyrs
Copy link
Author

pakyrs commented Jun 17, 2024

Yes the one from repo works fine, it's the one in the store that differ slightly and no longer works on code bloc highligting. Thanks for letting me know, for the moment I just manually replaced the css file.

@TheFrenchGhosty
Copy link

TheFrenchGhosty commented Sep 17, 2024

It's been 3 months and the problem is still present.

I had to find this issue to figure out that the weird way the code blocks were rendering were a bug...

The problem seems to also be present in the git version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants