Refactor to meet rubocop expectations

Author: Sebastian Wilgosz

Gemfile

@@ -1,7 +1,9 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in fast_cqrs.gemspec
 gemspec
 
-gem "rake", "~> 12.0"
-gem "rspec", "~> 3.0"
+gem 'rake', '~> 12.0'
+gem 'rspec', '~> 3.0'

Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "fast_cqrs"
+require 'bundler/setup'
+require 'fast_cqrs'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "fast_cqrs"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

fast_cqrs.gemspec

@@ -1,31 +1,33 @@
+# frozen_string_literal: true
+
 require_relative 'lib/fast_cqrs/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "fast_cqrs"
+  spec.name          = 'fast_cqrs'
   spec.version       = FastCqrs::VERSION
-  spec.authors       = ["Sebastian Wilgosz"]
-  spec.email         = ["[email protected]"]
+  spec.authors       = ['Sebastian Wilgosz']
+  spec.email         = ['[email protected]']
 
-  spec.summary       = %q{A lightweight CQRS scaffold for ruby-based web applications.}
-  spec.description   = %q{Write CQRS applications easily using functional endpoints without a hassle.}
-  spec.homepage      = "https://github.com/driggl/fast_cqrs"
-  spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.summary       = 'A lightweight CQRS scaffold for ruby-based web applications.'
+  spec.description   = 'Write CQRS applications easily using functional endpoints without a hassle.'
+  spec.homepage      = 'https://github.com/driggl/fast_cqrs'
+  spec.license       = 'MIT'
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')
 
   spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/driggl/fast_cqrs"
-  spec.metadata["changelog_uri"] = "https://github.com/driggl/fast_cqrs/releases"
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = 'https://github.com/driggl/fast_cqrs'
+  spec.metadata['changelog_uri'] = 'https://github.com/driggl/fast_cqrs/releases'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_dependency 'dry-matcher'
   spec.add_dependency 'dry-monads'

lib/fast_cqrs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fast_cqrs/version'
 require 'fast_cqrs/authorizer'
 require 'fast_cqrs/request'

lib/fast_cqrs/authorizer.rb

@@ -13,6 +13,7 @@ def self.inherited(klass)
 
     def call(**)
       return Success() if authorize
+
       fail!
     end
 

lib/fast_cqrs/deserializer/json_api.rb

@@ -28,4 +28,4 @@ def call(params = { data: {} })
       end
     end
   end
-end
+end

lib/fast_cqrs/transaction.rb

@@ -15,7 +15,7 @@ def self.inherited(klass)
       end
     end
 
-    def call(input, **)
+    def call(_input, **)
       Success()
     end
   end

lib/fast_cqrs/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FastCqrs
   VERSION = '0.1.1'
 end

spec/fast_cqrs/request_spec.rb

@@ -4,12 +4,12 @@
 
 module FastCqrs
   RSpec.describe Request do
-    describe "#call" do
+    describe '#call' do
       let(:deserializer) { double('deserializer') }
 
       context 'when valid request' do
         before do
-          allow(deserializer).to receive(:call) do |hash={}|
+          allow(deserializer).to receive(:call) do |_hash = {}|
             { foo: 'foo', bar: 'bar' }
           end
         end
@@ -22,8 +22,8 @@ module FastCqrs
 
       context 'when invalid request' do
         before do
-          allow(deserializer).to receive(:call) do |hash={}|
-            raise "Invalid request"
+          allow(deserializer).to receive(:call) do |_hash = {}|
+            raise 'Invalid request'
           end
         end
         subject { described_class.new(deserializer: deserializer) }
@@ -35,7 +35,6 @@ module FastCqrs
         end
       end
 
-
       context 'inherited invalid request' do
         subject { InvalidRequest.new(deserializer: Deserializer::JsonApi.new).call({}) }
 
@@ -60,15 +59,15 @@ class InvalidRequest < Request
     protected
 
     def model(_input)
-      return
+      nil
     end
   end
 
   class ValidRequest < Request
     protected
 
     def model(_input)
-      return { foo: 'foo', bar: 'bar' }
+      { foo: 'foo', bar: 'bar' }
     end
   end
 end

spec/fast_cqrs_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe FastCqrs do
-  it "has a version number" do
+  it 'has a version number' do
     expect(FastCqrs::VERSION).not_to be nil
   end
 end

spec/spec_helper.rb

@@ -1,11 +1,13 @@
-require "bundler/setup"
-require "fast_cqrs"
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'fast_cqrs'
 require 'dry/monads'
 
 RSpec.configure do |config|
   config.include include Dry::Monads[:result]
   # Enable flags like --only-failures and --next-failure
-  config.example_status_persistence_file_path = ".rspec_status"
+  config.example_status_persistence_file_path = '.rspec_status'
 
   # Disable RSpec exposing methods globally on `Module` and `main`
   config.disable_monkey_patching!