Skip to content

Commit ce2fae1

Browse files
committed
Improve compliance with style(9).
1 parent 4e4e91f commit ce2fae1

9 files changed

+228
-170
lines changed

config.c

+17-12
Original file line numberDiff line numberDiff line change
@@ -23,26 +23,28 @@
2323

2424
/* psk */
2525

26-
char * psk_get_key(char *id, psk *head)
26+
char *
27+
psk_get_key(char *id, psk *head)
2728
{
2829
char *key = NULL;
29-
for(psk *p = head; p && !key; p = p->next) {
30-
if(!strcmp(p->id, id) || !p->next)
30+
for (psk *p = head; p && !key; p = p->next) {
31+
if (!strcmp(p->id, id) || !p->next)
3132
key = p->key;
3233
}
3334

3435
return key;
3536
}
3637

37-
void psk_set_key(char *id, char *key, psk **head)
38+
void
39+
psk_set_key(char *id, char *key, psk **head)
3840
{
3941
psk *found = NULL;
40-
for(psk *p = *head; p && !found; p = p->next) {
41-
if(p->id == id)
42+
for (psk *p = *head; p && !found; p = p->next) {
43+
if (p->id == id)
4244
found = p;
4345
}
4446

45-
if(!found) {
47+
if (!found) {
4648
mem_allocate(&found, sizeof(psk));
4749
memset(found, 0, sizeof(psk));
4850
found->id = strdup(id);
@@ -53,7 +55,8 @@ void psk_set_key(char *id, char *key, psk **head)
5355
found->key = strdup(key);
5456
}
5557

56-
void psk_free(psk *keys)
58+
void
59+
psk_free(psk *keys)
5760
{
5861
mem_free(&keys->next);
5962
mem_free(&keys->id);
@@ -64,24 +67,26 @@ void psk_free(psk *keys)
6467

6568
/* config */
6669

67-
config * config_new()
70+
config *
71+
config_new()
6872
{
6973
config *cfg = NULL;
7074
mem_allocate(&cfg, sizeof(config));
7175
memset(cfg, 0, sizeof(config));
7276
return cfg;
7377
}
7478

75-
void config_free(config *cfg)
79+
void
80+
config_free(config *cfg)
7681
{
77-
if(cfg->us) {
82+
if (cfg->us) {
7883
udp_socket_free(cfg->us);
7984
cfg->us = NULL;
8085
}
8186

8287
mem_free(&cfg->gateway);
8388

84-
if(cfg->keys) {
89+
if (cfg->keys) {
8590
psk_free(cfg->keys);
8691
cfg->keys = NULL;
8792
}

datagram.c

+19-13
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@
3333
* Create a new datagram instance of given size.
3434
* If size is 0, make it as large as supported by UDP.
3535
*/
36-
datagram * datagram_new(size_t size)
36+
datagram *
37+
datagram_new(size_t size)
3738
{
38-
if(size == 0)
39+
if (size == 0)
3940
size = UDP_DGM_MAXSIZE;
4041
datagram *dgm = NULL;
4142
mem_allocate(&dgm, sizeof(datagram));
@@ -49,9 +50,10 @@ datagram * datagram_new(size_t size)
4950
/*
5051
* Free a datagram instance.
5152
*/
52-
void datagram_free(datagram *dgm)
53+
void
54+
datagram_free(datagram *dgm)
5355
{
54-
if(dgm) {
56+
if (dgm) {
5557
mem_free(&dgm->data);
5658
free(dgm);
5759
}
@@ -63,13 +65,14 @@ void datagram_free(datagram *dgm)
6365
* Open a UDP socket on the given port.
6466
* Will quit on errors.
6567
*/
66-
udp_socket * udp_socket_new(uint16_t port)
68+
udp_socket *
69+
udp_socket_new(uint16_t port)
6770
{
6871
udp_socket *s = NULL;
6972
mem_allocate(&s, sizeof(udp_socket));
7073
s->port = port;
7174
s->fd = socket(PF_INET, SOCK_DGRAM, 0);
72-
if(s->fd < 0) {
75+
if (s->fd < 0) {
7376
fprintf(stderr, "FATAL: socket(udp) returned %d: %s (%d)\n",
7477
s->fd, strerror(errno), errno);
7578
exit(-1);
@@ -80,7 +83,7 @@ udp_socket * udp_socket_new(uint16_t port)
8083
sa.sin_port = htons(s->port);
8184
sa.sin_addr.s_addr = htonl(INADDR_ANY);
8285
int ret = bind(s->fd, (struct sockaddr *)&sa, sizeof(sa));
83-
if(ret < 0) {
86+
if (ret < 0) {
8487
fprintf(stderr, "FATAL: bind(%d/udp) returned %d: %s (%d)\n",
8588
s->port, ret, strerror(errno), errno);
8689
exit(-1);
@@ -92,9 +95,10 @@ udp_socket * udp_socket_new(uint16_t port)
9295
/*
9396
* Close UDP socket.
9497
*/
95-
void udp_socket_free(udp_socket *s)
98+
void
99+
udp_socket_free(udp_socket *s)
96100
{
97-
if(s) {
101+
if (s) {
98102
close(s->fd);
99103
free(s);
100104
}
@@ -104,14 +108,15 @@ void udp_socket_free(udp_socket *s)
104108
* Receive next incoming UDP datagram on socket s.
105109
* Blocks until a datagram is received.
106110
*/
107-
datagram * udp_socket_recv(udp_socket *s)
111+
datagram *
112+
udp_socket_recv(udp_socket *s)
108113
{
109114
char buf[UDP_DGM_MAXSIZE];
110115
struct sockaddr_in sa;
111116
socklen_t sa_len = sizeof(sa);
112117
int ret = recvfrom(s->fd, buf, sizeof(buf), 0,
113118
(struct sockaddr *)&sa, &sa_len);
114-
if(ret < 0) {
119+
if (ret < 0) {
115120
log_printf(NULL, "ERROR: recvfrom(%d) returned %d: %s (%d)\n",
116121
s->fd, ret, strerror(errno), errno);
117122
}
@@ -126,11 +131,12 @@ datagram * udp_socket_recv(udp_socket *s)
126131
/*
127132
* Send a UDP datagram onto socket s.
128133
*/
129-
void udp_socket_send(udp_socket *s, datagram *dgm)
134+
void
135+
udp_socket_send(udp_socket *s, datagram *dgm)
130136
{
131137
int ret = sendto(s->fd, dgm->data, dgm->len, 0,
132138
(struct sockaddr*)&dgm->peer_addr, sizeof(dgm->peer_addr));
133-
if(ret < 0) {
139+
if (ret < 0) {
134140
log_printf(NULL, "ERROR: sendto(%d to %s:%d) returned %d: %s (%d)\n",
135141
s->fd, inet_ntoa(dgm->peer_addr.sin_addr),
136142
ntohs(dgm->peer_addr.sin_port),

0 commit comments

Comments
 (0)