Fix script edit tools retrying non-idempotent commands during reload

When Unity enters domain reload after a script edit, the retry loop in
send_command_with_retry would re-send the identical edit command up to
40 times, duplicating insert_method/anchor_insert edits. Pass
retry_on_reload=False on all script-mutating send calls since the edit
lands on disk before the reload triggers.

Also fix _flip_async coroutine in apply_text_edits that was passed as a
threading.Thread target — the coroutine was never awaited. Replace with
asyncio.create_task so the sentinel reload flip actually executes.

Fixes CoplayDev#790

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: dsarno

Server/src/services/tools/manage_script.py

@@ -11,6 +11,9 @@
 from transport.unity_transport import send_with_unity_instance
 import transport.legacy.unity_connection
 
+# Strong references to fire-and-forget tasks to prevent GC before completion
+_background_tasks: set = set()
+
 
 def _split_uri(uri: str) -> tuple[str, str]:
     """Split an incoming URI or path into (name, directory) suitable for Unity.
@@ -326,6 +329,7 @@ def _le(a: tuple[int, int], b: tuple[int, int]) -> bool:
         unity_instance,
         "manage_script",
         params,
+        retry_on_reload=False,
     )
     if isinstance(resp, dict):
         data = resp.setdefault("data", {})
@@ -335,8 +339,7 @@ def _le(a: tuple[int, int], b: tuple[int, int]) -> bool:
         if resp.get("success") and (options or {}).get("force_sentinel_reload"):
             # Optional: flip sentinel via menu if explicitly requested
             try:
-                import threading
-                import time
+                import asyncio
                 import json
                 import glob
                 import os
@@ -354,7 +357,7 @@ def _latest_status() -> dict | None:
 
                 async def _flip_async():
                     try:
-                        time.sleep(0.1)
+                        await asyncio.sleep(0.1)
                         st = _latest_status()
                         if st and st.get("reloading"):
                             return
@@ -367,7 +370,9 @@ async def _flip_async():
                         )
                     except Exception:
                         pass
-                threading.Thread(target=_flip_async, daemon=True).start()
+                task = asyncio.create_task(_flip_async())
+                _background_tasks.add(task)
+                task.add_done_callback(_background_tasks.discard)
             except Exception:
                 pass
             return resp
@@ -423,6 +428,7 @@ async def create_script(
         unity_instance,
         "manage_script",
         params,
+        retry_on_reload=False,
     )
     return resp if isinstance(resp, dict) else {"success": False, "message": str(resp)}
 
@@ -452,6 +458,7 @@ async def delete_script(
         unity_instance,
         "manage_script",
         params,
+        retry_on_reload=False,
     )
     return resp if isinstance(resp, dict) else {"success": False, "message": str(resp)}
 
@@ -551,6 +558,7 @@ async def manage_script(
             unity_instance,
             "manage_script",
             params,
+            retry_on_reload=(action == "read"),
         )
 
         if isinstance(response, dict):

Server/src/services/tools/script_apply_edits.py

@@ -970,6 +970,7 @@ def error_with_hint(message: str, expected: dict[str, Any], suggestion: dict[str
             unity_instance,
             "manage_script",
             params_struct,
+            retry_on_reload=False,
         )
         if isinstance(resp_struct, dict) and resp_struct.get("success"):
             pass  # Optional sentinel reload removed (deprecated)
@@ -1110,6 +1111,7 @@ def _expand_dollars(rep: str, _m=m) -> str:
                     unity_instance,
                     "manage_script",
                     params_text,
+                    retry_on_reload=False,
                 )
                 if not (isinstance(resp_text, dict) and resp_text.get("success")):
                     return _with_norm(resp_text if isinstance(resp_text, dict) else {"success": False, "message": str(resp_text)}, normalized_for_echo, routing="mixed/text-first")
@@ -1135,6 +1137,7 @@ def _expand_dollars(rep: str, _m=m) -> str:
                 unity_instance,
                 "manage_script",
                 params_struct,
+                retry_on_reload=False,
             )
             if isinstance(resp_struct, dict) and resp_struct.get("success"):
                 pass  # Optional sentinel reload removed (deprecated)
@@ -1267,6 +1270,7 @@ def _expand_dollars(rep: str, _m=m) -> str:
                 unity_instance,
                 "manage_script",
                 params,
+                retry_on_reload=False,
             )
             if isinstance(resp, dict) and resp.get("success"):
                 pass  # Optional sentinel reload removed (deprecated)
@@ -1356,6 +1360,7 @@ def _expand_dollars(rep: str, _m=m) -> str:
         unity_instance,
         "manage_script",
         params,
+        retry_on_reload=False,
     )
     if isinstance(write_resp, dict) and write_resp.get("success"):
         pass  # Optional sentinel reload removed (deprecated)