Skip to content

Commit 8147950

Browse files
authored
Merge branch 'master' into fix/SchannelSettings
2 parents 1769503 + 14bedf3 commit 8147950

9 files changed

+47
-92
lines changed

CHANGELOG.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
1-
# Change log for SChannelDsc
1+
# Changelog for SChannelDsc
22

33
The format is based on and uses the types of changes according to [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

66
## [Unreleased]
77

8+
### Changed
9+
10+
- SChannelDsc
11+
- Moved some documentation from the README.md to the GitHub repository
12+
wiki page.
13+
- Updated the pipeline files to use the latest from Sampler.
14+
815
### Fixed
916

1017
- SChannelDsc

GitVersion.yml

+1-14
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
mode: ContinuousDelivery
2-
next-version: 1.2.0
2+
next-version: 0.0.1
33
major-version-bump-message: '(breaking\schange|breaking|major)\b'
44
minor-version-bump-message: '(adds?|features?|minor)\b'
55
patch-version-bump-message: '\s?(fix|patch)'
@@ -25,16 +25,3 @@ branches:
2525
ignore:
2626
sha: []
2727
merge-message-formats: {}
28-
29-
30-
# feature:
31-
# tag: useBranchName
32-
# increment: Minor
33-
# regex: f(eature(s)?)?[/-]
34-
# source-branches: ['master']
35-
# hotfix:
36-
# tag: fix
37-
# increment: Patch
38-
# regex: (hot)?fix(es)?[/-]
39-
# source-branches: ['master']
40-

LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2022 DSC Community
3+
Copyright (c) DSC Community contributors.
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

+7-43
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
# SChannelDsc
22

3+
This module contains DSC resources for the management and
4+
configuration of SChannel settings.
5+
6+
> It is based of the [cSchannel](https://github.com/bdanse/cSchannel) resource created by Bart Danse.
7+
38
[![Build Status](https://dev.azure.com/dsccommunity/SChannelDsc/_apis/build/status/dsccommunity.SChannelDsc?branchName=master)](https://dev.azure.com/dsccommunity/SChannelDsc/_build/latest?definitionId=32&branchName=master)
49
![Azure DevOps coverage (branch)](https://img.shields.io/azure-devops/coverage/dsccommunity/SChannelDsc/32/master)
10+
[![codecov](https://codecov.io/gh/dsccommunity/SChannelDsc/branch/master/graph/badge.svg)](https://codecov.io/gh/dsccommunity/SChannelDsc)
511
[![Azure DevOps tests](https://img.shields.io/azure-devops/tests/dsccommunity/SChannelDsc/32/master)](https://dsccommunity.visualstudio.com/SChannelDsc/_test/analytics?definitionId=32&contextType=build)
612
[![PowerShell Gallery (with prereleases)](https://img.shields.io/powershellgallery/vpre/SChannelDsc?label=SChannelDsc%20Preview)](https://www.powershellgallery.com/packages/SChannelDsc/)
713
[![PowerShell Gallery](https://img.shields.io/powershellgallery/v/SChannelDsc?label=SChannelDsc)](https://www.powershellgallery.com/packages/SChannelDsc/)
814

9-
The SChannelDsc PowerShell module provides DSC resources that can be used to
10-
manage SChannel settings. It is based of the [cSchannel](https://github.com/bdanse/cSchannel)
11-
resource created by Bart Danse.
12-
13-
Please leave comments, feature requests, and bug reports in the issues tab for
14-
this module.
1515
## Code of Conduct
1616

1717
This project has adopted this [Code of Conduct](CODE_OF_CONDUCT.md).
@@ -37,45 +37,9 @@ The documentation can be found in the [SChannelDsc Wiki](https://github.com/dscc
3737
The DSC resources schema files is used to automatically update the
3838
documentation on each PR merge.
3939

40-
## Installation
41-
42-
To manually install the module, download the source code and unzip the contents
43-
of the \Modules\SChannelDsc directory to the
44-
$env:ProgramFiles\WindowsPowerShell\Modules folder
45-
46-
To install from the [PowerShell Gallery](https://www.powershellgallery.com/packages/SChannelDsc)
47-
using PowerShellGet (in PowerShell 5.0) run the following command:
48-
49-
```PowerShell
50-
Find-Module -Name SChannelDsc -Repository PSGallery | Install-Module
51-
```
52-
53-
To confirm installation, run the below command and ensure you see the
54-
SChannel DSC resoures available:
55-
56-
```PowerShell
57-
Get-DscResource -Module SChannelDsc
58-
```
59-
60-
## Requirements
61-
62-
The minimum PowerShell version required is 4.0, which ships in Windows 8.1
63-
or Windows Server 2012R2 (or higher versions). The preferred version is
64-
PowerShell 5.0 or higher, which ships with Windows 10 or Windows Server 2016.
65-
This is discussed [on the SChannelDsc wiki](https://github.com/dsccommunity/SChannelDsc/wiki/Remote%20sessions%20and%20the%20InstallAccount%20variable),
66-
but generally PowerShell 5 will run the SChannel DSC resources faster and
67-
with improved verbose level logging.
68-
69-
## Documentation and examples
70-
71-
For a full list of resources in SChannelDsc and examples on their use, check
72-
out the [SChannelDsc wiki](https://github.com/dsccommunity/SChannelDsc/wiki).
73-
You can also review the "examples" directory in the SChannelDsc module for
74-
some general use scenarios for all of the resources that are in the module.
75-
7640
### Examples
7741

78-
You can review the [Examples](/source/Examples) directory in the Temp module
42+
You can review the [Examples](/source/Examples) directory in the SChannelDsc module
7943
for some general use scenarios for all of the resources that are in the module.
8044

8145
The resource examples are also available in the [SChannelDsc Wiki](https://github.com/dsccommunity/SChannelDsc/wiki).

azure-pipelines.yml

+16-29
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,17 @@ stages:
2525
- job: Package_Module
2626
displayName: 'Package Module'
2727
pool:
28-
vmImage: 'ubuntu-18.04'
28+
vmImage: 'ubuntu-latest'
2929
steps:
30-
- task: GitVersion@5
31-
name: gitVersion
32-
displayName: 'Evaluate Next Version'
33-
inputs:
34-
runtime: 'core'
35-
configFilePath: 'GitVersion.yml'
36-
30+
- pwsh: |
31+
dotnet tool install --global GitVersion.Tool
32+
$gitVersionObject = dotnet-gitversion | ConvertFrom-Json
33+
$gitVersionObject.PSObject.Properties.ForEach{
34+
Write-Host -Object "Setting Task Variable '$($_.Name)' with value '$($_.Value)'."
35+
Write-Host -Object "##vso[task.setvariable variable=$($_.Name);]$($_.Value)"
36+
}
37+
Write-Host -Object "##vso[build.updatebuildnumber]$($gitVersionObject.FullSemVer)"
38+
displayName: Calculate ModuleVersion (GitVersion)
3739
- task: PowerShell@2
3840
name: package
3941
displayName: 'Build & Package Module'
@@ -42,8 +44,7 @@ stages:
4244
arguments: '-ResolveDependency -tasks pack'
4345
pwsh: true
4446
env:
45-
ModuleVersion: $(gitVersion.NuGetVersionV2)
46-
47+
ModuleVersion: $(NuGetVersionV2)
4748
- task: PublishPipelineArtifact@1
4849
displayName: 'Publish Build Artifact'
4950
inputs:
@@ -52,21 +53,13 @@ stages:
5253
publishLocation: 'pipeline'
5354
parallel: true
5455

55-
- task: PublishPipelineArtifact@1
56-
displayName: 'Publish Wiki Content Artifact'
57-
inputs:
58-
targetPath: '$(buildFolderName)/WikiContent/'
59-
artifact: 'WikiContent'
60-
publishLocation: 'pipeline'
61-
parallel: true
62-
6356
- stage: Test
6457
dependsOn: Build
6558
jobs:
6659
- job: Test_HQRM
6760
displayName: 'HQRM'
6861
pool:
69-
vmImage: 'windows-2022'
62+
vmImage: 'windows-latest'
7063
timeoutInMinutes: 0
7164
steps:
7265
- task: DownloadPipelineArtifact@2
@@ -75,15 +68,13 @@ stages:
7568
buildType: 'current'
7669
artifactName: $(buildArtifactName)
7770
targetPath: '$(Build.SourcesDirectory)/$(buildFolderName)'
78-
7971
- task: PowerShell@2
8072
name: test
8173
displayName: 'Run HQRM Test'
8274
inputs:
8375
filePath: './build.ps1'
8476
arguments: '-Tasks hqrmtest'
8577
pwsh: false
86-
8778
- task: PublishTestResults@2
8879
displayName: 'Publish Test Results'
8980
condition: succeededOrFailed()
@@ -96,7 +87,7 @@ stages:
9687
- job: Test_Unit
9788
displayName: 'Unit'
9889
pool:
99-
vmImage: 'windows-2022'
90+
vmImage: 'windows-latest'
10091
timeoutInMinutes: 0
10192
steps:
10293
- task: DownloadPipelineArtifact@2
@@ -105,15 +96,13 @@ stages:
10596
buildType: 'current'
10697
artifactName: $(buildArtifactName)
10798
targetPath: '$(Build.SourcesDirectory)/$(buildFolderName)'
108-
10999
- task: PowerShell@2
110100
name: test
111101
displayName: 'Run Unit Test'
112102
inputs:
113103
filePath: './build.ps1'
114104
arguments: "-Tasks test -PesterScript 'tests/Unit'"
115-
pwsh: false
116-
105+
pwsh: true
117106
- task: PublishTestResults@2
118107
displayName: 'Publish Test Results'
119108
condition: succeededOrFailed()
@@ -122,7 +111,6 @@ stages:
122111
testResultsFiles: '$(buildFolderName)/$(testResultFolderName)/NUnit*.xml'
123112
# If several pipeline jobs are generating test result, consider renaming this title:
124113
testRunTitle: 'Unit'
125-
126114
- task: PublishPipelineArtifact@1
127115
displayName: 'Publish Test Artifact'
128116
inputs:
@@ -136,7 +124,7 @@ stages:
136124
displayName: 'Publish Code Coverage'
137125
dependsOn: Test_Unit
138126
pool:
139-
vmImage: 'ubuntu-18.04'
127+
vmImage: 'ubuntu-latest'
140128
timeoutInMinutes: 0
141129
steps:
142130
- pwsh: |
@@ -157,7 +145,6 @@ stages:
157145
buildType: 'current'
158146
artifactName: $(testArtifactName)
159147
targetPath: '$(Build.SourcesDirectory)/$(buildFolderName)/$(testResultFolderName)'
160-
161148
- task: PublishCodeCoverageResults@1
162149
displayName: 'Publish Code Coverage to Azure DevOps'
163150
inputs:
@@ -183,7 +170,7 @@ stages:
183170
- job: Deploy_Module
184171
displayName: 'Deploy Module'
185172
pool:
186-
vmImage: 'ubuntu-18.04'
173+
vmImage: 'ubuntu-latest'
187174
steps:
188175
- task: DownloadPipelineArtifact@2
189176
displayName: 'Download Pipeline Artifact'

build.ps1

+1-1
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ Begin
466466
# The parameter has been explicitly used for calling the .build.ps1
467467
if ($MyInvocation.BoundParameters.ContainsKey($cmdParameter))
468468
{
469-
$paramValue = $MyInvocation.BoundParameters.ContainsKey($cmdParameter)
469+
$paramValue = $MyInvocation.BoundParameters.Item($cmdParameter)
470470

471471
Write-Debug " adding $cmdParameter :: $paramValue [from user-provided parameters to Build.ps1]"
472472

build.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ BuildWorkflow:
3434
- Build_Module_ModuleBuilder
3535
- Build_NestedModules_ModuleBuilder
3636
- Create_changelog_release_output
37-
# - Generate_Conceptual_Help
37+
- Generate_Conceptual_Help
3838
- Generate_Wiki_Content
3939

4040
pack:
@@ -81,7 +81,7 @@ DscTest:
8181
ExcludeSourceFile:
8282
- output
8383
ExcludeModuleFile:
84-
- Modules/DscResource.Common
84+
- Modules/DscResource.Common
8585

8686
# Import ModuleBuilder tasks from a specific PowerShell module using the build
8787
# task's alias. Wildcard * can be used to specify all tasks that has a similar

source/SChannelDsc.psm1

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<#
2+
This file is intentionally left empty. It is must be left here for the module
3+
manifest to refer to. It is recreated during the build process.
4+
#>

source/WikiSource/Home.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,13 @@ To confirm installation, run the below command and ensure you see the SChannel D
1717

1818
Get-DscResource -Module SChannelDsc
1919

20-
#### DSC requirements
20+
## Requirements
21+
22+
The minimum PowerShell version required is 4.0, which ships in Windows 8.1
23+
or Windows Server 2012R2 (or higher versions). The preferred version is
24+
PowerShell 5.0 or higher, which ships with Windows 10 or Windows Server 2016.
25+
26+
### DSC requirements
2127

2228
To run PowerShell DSC, you need to have PowerShell 4.0 or higher (which is included in Windows Management Framework 4.0 or higher).
2329
This version of PowerShell is shipped with Windows Server 2012 R2, and Windows 8.1 or higher.

0 commit comments

Comments
 (0)