Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of asyncio.get_event_loop() if there is no running event loop #28

Open
stfwn opened this issue Feb 21, 2022 · 0 comments · May be fixed by #29
Open

Deprecation of asyncio.get_event_loop() if there is no running event loop #28

stfwn opened this issue Feb 21, 2022 · 0 comments · May be fixed by #29

Comments

@stfwn
Copy link

stfwn commented Feb 21, 2022

Hi! Thanks for writing and maintaining this module! 😄

The Python 3.10 docs for asyncio.get_event_loop() note:

Deprecated since version 3.10: Deprecation warning is emitted if there is no running event loop. In future Python releases, this function will be an alias of get_running_loop().

It seems @async_handler will fail with RuntimeError: no running event loop in that case. Do you think this correct?

Perhaps a solution is to effectively move the deprecated functionality into the module itself. I created a PR for this.

@stfwn stfwn linked a pull request Feb 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant