Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the wind vector grid to earth rotation logic for non-conformal projections #2712

Open
8 of 21 tasks
JohnHalleyGotway opened this issue Oct 12, 2023 · 0 comments
Open
8 of 21 tasks
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: input data Input data issue MET: Grid Library Grid and Projection Library Items MET: Wind Verification priority: high High Priority requestor: Community General Community type: enhancement Improve something that it is currently doing

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Enhancement

This issue is related to bugfix #2711. As noted in this comment, MET's current logic for rotating wind vectors from grid-relative to earth-relative for non-conformal projections is not mathematically correct.

This issue is to investigate both the math required to do this correctly as well as existing conventions as to if/how this is handled elsewhere. Recommend checking python functionality and well as the Proj library to see if/how grid to earth rotations for non-conformal grids are handled.

Also recommend discussing this potential change for MET version 12.0.0 with members of the METplus Governance committee (e.g. NOAA, NRL, MetOffice, BOM) to ensure that this potential change is consistent with their datasets.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: Community General Community alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue priority: high High Priority component: input data Input data issue labels Oct 12, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Oct 12, 2023
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 📖 Backlog to 🟢 Ready in MET-12.1.0 Development Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway added MET: Grid Library Grid and Projection Library Items MET: Wind Verification labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: input data Input data issue MET: Grid Library Grid and Projection Library Items MET: Wind Verification priority: high High Priority requestor: Community General Community type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants