Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance multivariate MODE to support Python embedding inputs #2940

Open
9 of 21 tasks
JohnHalleyGotway opened this issue Jul 30, 2024 · 1 comment
Open
9 of 21 tasks
Assignees
Labels
MET: Object Verification Object-based feature Verification MET: Python Embedding priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jul 30, 2024

Describe the Enhancement

This issue is based on the dtcenter/METplus#2644 discussion. @CPKalb has found that running multi-variate MODE with 2 inputs that use Python embedding does not work as expected. @JohnHalleyGotway tested multivariate MODE directly and found that it errors out when parsing an input file list containing PYTHON_NUMPY PYTHON_NUMPY. Since those are not filenames that actually exist on the file system, it treats them as being missing files and thinks that it has 0 inputs.

This task is to do the following:

  1. Spend a couple of hours investigating this issue to see layering in Python embedding support is easily done. If so, fix this for the MET-12.0.0 release. If the issue is more involved, reassign this work to the next coordinated release.
  2. Enhance multivariate MODE to support Python embedding inputs.
  3. Add a unit test to demonstrate this functionality.
  4. Review the documentation for needed changes.

Time Estimate

Approx 2 days.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7760062 Integrating Fire Wx (but confirm first)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory MET: Object Verification Object-based feature Verification MET: Python Embedding labels Jul 30, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Jul 30, 2024
@JohnHalleyGotway JohnHalleyGotway self-assigned this Jul 30, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 📖 Backlog to 🟢 Ready in MET-12.1.0 Development Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 3, 2024
@JohnHalleyGotway
Copy link
Collaborator Author

@j-opatz please take a look at this issue.

@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Object Verification Object-based feature Verification MET: Python Embedding priority: medium Medium Priority requestor: NCAR/RAL NCAR Research Applications Laboratory type: enhancement Improve something that it is currently doing
Projects
Status: 🟢 Ready
Development

No branches or pull requests

2 participants