Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to the Gulf of America #3098

Open
8 of 21 tasks
JohnHalleyGotway opened this issue Mar 4, 2025 · 0 comments · Fixed by #3101
Open
8 of 21 tasks

Update references to the Gulf of America #3098

JohnHalleyGotway opened this issue Mar 4, 2025 · 0 comments · Fixed by #3101
Assignees
Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Task

As discussed during METplus NOAA User Telecon on March 3, 2025 (see notes) and confirmed via email afterwards, the MET repository should be updated based on the Gulf of America name change. Similar changes have already been made in the NOAA/EVS repository and can be used as a reference.

The location of the changes include:

Docs: descriptions could be modified:
./docs/Users_Guide/appendixB.rst:* GLF.poly for the Gulf of Mexico
./docs/Users_Guide/appendixB.rst:* GMC.poly for the Gulf of Mexico Coast

Data: GMC could be renamed as GAC.
./data/poly/NCEP_masks/GMC_mask.nc
./data/poly/GMC.poly
./data/poly/ncep_vx_regions.pdf

Time Estimate

2 hours

Sub-Issues

Consider breaking the task down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2783544 NOAA R2O METplus?

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: task An actionable item of work labels Mar 4, 2025
@JohnHalleyGotway JohnHalleyGotway self-assigned this Mar 4, 2025
@JohnHalleyGotway JohnHalleyGotway added component: code cleanup Code cleanup and maintenance issue requestor: NOAA/EMC NOAA Environmental Modeling Center reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project priority: high High Priority and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Mar 4, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1.0 Development Mar 4, 2025
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.1.0 milestone Mar 4, 2025
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🎯 Up Next in METplus-6.1.0 Development Mar 4, 2025
@JohnHalleyGotway JohnHalleyGotway moved this from 🎯 Up Next to 🏗 In progress in METplus-6.1.0 Development Mar 7, 2025
JohnHalleyGotway added a commit that referenced this issue Mar 7, 2025
@JohnHalleyGotway JohnHalleyGotway linked a pull request Mar 7, 2025 that will close this issue
17 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🏗 In progress to 🔎 In review in METplus-6.1.0 Development Mar 7, 2025
JohnHalleyGotway added a commit that referenced this issue Mar 10, 2025
* Per #3098, change references to America and modify the GMC polyline name to GAC throughout.

* Per #3098, also need to handle the GMC to GAC file name change in the Makefiles.
@JohnHalleyGotway JohnHalleyGotway moved this from 🔎 In review to 🏁 Done in METplus-6.1.0 Development Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue priority: high High Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: task An actionable item of work
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant