Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return error code > 0 if the only issues found are warnings #47

Closed
federicobond opened this issue Nov 1, 2016 · 6 comments
Closed

Comments

@federicobond
Copy link
Contributor

No description provided.

@MicahZoltu
Copy link

This is the opposite of what I want (I actually came here to see if there was an option for marking warnings as errors). If this is added, please be sure to make it configurable.

@duaraghav8
Copy link
Owner

@MicahZoltu next version of solium will allow you to configure whether to treat a rule as warning, error or turn it off altogether, similar to eslint.
eg- https://github.com/duaraghav8/Solium/blob/master/config/rulesets/solium-all.js

Plus you can pass options like quotes: ["warning", "double"].

The cli will only return non-zero exit code if any errors exist.
Thanks @federicobond

@elenadimitrova
Copy link

@duaraghav8 is there a way to treat all warnings as errors, rather than word them out individually?

@duaraghav8
Copy link
Owner

duaraghav8 commented Jan 15, 2019

@elenadimitrova currently no. But I can see why this can be quite inconvenient. Do you have any ideas on how this configuration option should be presented to the end user? I can't think of a way which could be easy and also provide some flexibility (i.e. treat all as warnings or errors).

@elenadimitrova
Copy link

elenadimitrova commented Jan 16, 2019

@duaraghav8 Perhaps we can go for a --strict option which does the switch from all warnings to errors but also honours the rules config that is additionally allowed to override behaviour in both strict and normal runs?

@duaraghav8
Copy link
Owner

moving discussion to #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants