-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return error code > 0 if the only issues found are warnings #47
Comments
This is the opposite of what I want (I actually came here to see if there was an option for marking warnings as errors). If this is added, please be sure to make it configurable. |
@MicahZoltu next version of solium will allow you to configure whether to treat a rule as warning, error or turn it off altogether, similar to eslint. Plus you can pass options like The cli will only return non-zero exit code if any errors exist. |
@duaraghav8 is there a way to treat all warnings as errors, rather than word them out individually? |
@elenadimitrova currently no. But I can see why this can be quite inconvenient. Do you have any ideas on how this configuration option should be presented to the end user? I can't think of a way which could be easy and also provide some flexibility (i.e. treat all as warnings or errors). |
@duaraghav8 Perhaps we can go for a |
moving discussion to #252 |
No description provided.
The text was updated successfully, but these errors were encountered: