Merge branch 'main' into fix/python-udf-refcount-leak

Author: evertlammerts

cmake/duckdb_loader.cmake

@@ -115,15 +115,19 @@ function(_duckdb_validate_jemalloc_config)
   endif()
 
   # jemalloc is only allowed in linux and osx debug builds
-  set(supported_os
-      CMAKE_SYSTEM_NAME
-      STREQUAL
-      "Darwin"
-      OR
-      CMAKE_SYSTEM_NAME
-      STREQUAL
-      "Linux")
-  set(jemalloc_allowed CMAKE_BUILD_TYPE STREQUAL "Debug" AND supported_os)
+  if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" OR CMAKE_SYSTEM_NAME STREQUAL "Linux")
+    set(supported_os TRUE)
+  else()
+    set(supported_os FALSE)
+  endif()
+
+  # jemalloc is only allowed in debug builds
+  if(CMAKE_BUILD_TYPE STREQUAL "Debug" AND supported_os)
+    set(jemalloc_allowed TRUE)
+  else()
+    set(jemalloc_allowed FALSE)
+  endif()
+
   if(NOT jemalloc_allowed)
     message(
       WARNING
@@ -247,6 +251,11 @@ function(duckdb_add_library target_name)
 
   # Create clean interface target
   _duckdb_create_interface_target(${target_name})
+
+  # Propagate BUILD_EXTENSIONS back to caller scope in case it was modified
+  set(BUILD_EXTENSIONS
+      "${BUILD_EXTENSIONS}"
+      PARENT_SCOPE)
 endfunction()
 
 function(duckdb_link_extensions target_name)

src/duckdb_py/pyrelation.cpp

@@ -153,7 +153,7 @@ unique_ptr<DuckDBPyRelation> DuckDBPyRelation::ProjectFromTypes(const py::object
 			if (!projection.empty()) {
 				projection += ", ";
 			}
-			projection += names[i];
+			projection += KeywordHelper::WriteOptionallyQuoted(names[i]);
 		}
 	}
 	if (projection.empty()) {

tests/fast/test_relation.py

@@ -688,3 +688,10 @@ def create_view(con, view_name: str) -> None:
 
         res = con.sql("select * from vw").fetchall()
         assert res == expected
+
+    def test_relation_select_dtypes_quotes_identifiers_with_spaces(self, duckdb_cursor):
+        df = pd.DataFrame({"na me": ["alice", "bob"], "x": [1, 2]})
+        rel = duckdb_cursor.from_df(df)
+        out = rel.select_dtypes([duckdb.sqltypes.VARCHAR]).fetchdf()
+        assert list(out.columns) == ["na me"]
+        assert out["na me"].tolist() == ["alice", "bob"]