Skip to content

Make the HTTP client backend used by Bucket pluggable #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandry wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Make the HTTP client backend used by Bucket pluggable #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d0b6b0
Refactor to aid upcoming change to HTTP request backend API.
vandry Nov 20, 2025
a240b05
Deliver requests to all 3 backends in http::Request format.
vandry Nov 21, 2025
d008813
Fix and deduplicate unit tests after the http::Request refactor.
vandry Nov 22, 2025
758216f
Deliver responses from all 3 backends in http::Response format.
vandry Nov 22, 2025
a876546
Move backend-specific options from Bucket to individual backends.
vandry Nov 23, 2025
dbc7b5a
Refactor to aid upcoming change to HTTP request backend API (bis).
vandry Nov 23, 2025
ea7c61a
Use tower::Service (or a sync version of it) to interface with backends.
vandry Nov 23, 2025
0eb0f37
Rearrange the order of some method in impl Bucket. No functional change.
vandry Nov 26, 2025
5a48df0
Make the request backend pluggable.
vandry Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions s3/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ futures-util = { version = "0.3", optional = true, default-features = false }
hex = "0.4"
hmac = "0.12"
http = "1"
http-body = { version = "1.0.1", optional = true }
http-body-util = { version = "0.1.3", optional = true }
log = "0.4"
maybe-async = { version = "0.2" }
md5 = "0.8"
Expand All @@ -79,15 +81,16 @@ tokio = { version = "1", features = [
"io-util",
], optional = true, default-features = false }
tokio-stream = { version = "0.1", optional = true }
tower-service = { version = "0.3.3", optional = true }
url = "2"

[features]
default = ["fail-on-err", "tags", "tokio-native-tls"]

sync = ["attohttpc", "maybe-async/is_sync"]
with-async-std-hyper = ["with-async-std", "surf/hyper-client"]
with-async-std = ["async-std", "futures-util", "surf", "sysinfo"]
with-tokio = ["futures-util", "reqwest", "tokio", "tokio/fs", "tokio-stream", "sysinfo"]
with-async-std = ["dep:http-body", "dep:http-body-util", "dep:tower-service", "async-std", "futures-util", "surf", "sysinfo"]
with-tokio = ["dep:http-body", "dep:http-body-util", "dep:tower-service", "futures-util", "reqwest", "tokio", "tokio/fs", "tokio-stream", "sysinfo"]

blocking = ["block_on_proc", "tokio/rt", "tokio/rt-multi-thread"]
fail-on-err = []
Expand Down
Loading