Skip to content

cpp tests not run on ci #269

@epicfarmer

Description

@epicfarmer

Description
Only the python tests are run on CI. As a result, the tests are broken.

To Reproduce

  • checkout repo
  • run cmake -S. -Bbuild -DMINORMINER_BUILD_TESTS=ON
  • run cmake --build build

Expected behavior

> cmake --build build
[ 12%] Building CXX object googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
In file included from .../minorminer/build/googletest-src/googletest/src/gtest-all.cc:42:
.../minorminer/build/googletest-src/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
.../minorminer/build/googletest-src/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
.../minorminer/build/googletest-src/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
.../minorminer/build/googletest-src/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors
gmake[2]: *** [googletest-build/googletest/CMakeFiles/gtest.dir/build.make:79: googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:236: googletest-build/googletest/CMakeFiles/gtest.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

Environment:

  • OS: [Ubuntu 24.10 ]

Additional context
I tried disabing werror in google-test, and tests still failed due to a missing <memory> include.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions