Skip to content

fix status implementation #115

@dlopes7

Description

@dlopes7

The Status implementation is all over the place, we have:

  • Status
  • IgnoreStatus - which is a standalone class that doesn't represent anything
  • MultiStatus
  • EndpointStatus
  • EndpointStatuses

And keep checking for isinstance in several places, none of these classes seem to be related to one another, they don't inherit from the same class, they have completely different methods between themselves.

The query method is also broken in typecheck because we introduced a return IgnoreStatus for some reason but did not update the method signature

We need to clean this up, make a Status interface that the other ones implement, correctly type the methods that use it and also add documentation of how to use Status.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions