Multiple fixes to improve performance of the new label screen #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can reuse existing directives after re-initializing, which improves performance. https://www.codelord.net/2017/01/25/techniques-for-improving-ng-repeat-performance/ aquint/ion-alpha-scroll#5 https://medium.com/littleiffel/angularjs-my-solution-to-the-ng-repeat-performance-problem-7a3534658bbe This means that the directives are initialized without a trip, so we need to check for trip existence before accessing any trip fields e-mission/e-mission-docs#819 (comment) e-mission/e-mission-docs#819 (comment) e-mission/e-mission-docs#819 (comment)
- Convert the mapLimiter from a potentially modifiable `$scope` variable to a const, so angular doesn't need to watch it - Change the schedule so that we pass in the promise to schedule, and handle the callback from the schedule callback. This ensures that we launch the location data code after the list has been displayed ``` [Log] DEBUG:After adding batch of size 39 cumulative size = 39 (index.html, line 154) [Log] DEBUG:new end time = 1665705805.000558 (index.html, line 154) [Log] true (index.html, line 154, x39) [Log] DEBUG:Broadcasting infinite scroll complete (index.html, line 154) [Log] DEBUG:infiniteScrollComplete broadcast (index.html, line 154) ... [Log] DEBUG:About to pull location data for range Thu Oct 20 2022 15:51:18 GMT-0700 -> Thu Oct 20 2022 16:14:32 GMT-0700 [Log] DEBUG:About to pull location data for range Thu Oct 20 2022 10:20:23 GMT-0700 -> Thu Oct 20 2022 10:22:34 GMT-0700 DEBUG:About to pull location data for range Thu Oct 20 2022 08:21:40 GMT-0700 -> Thu Oct 20 2022 08:34:07 GMT-0700 ... [Log] DEBUG:Retrieved 52 points at Tue Oct 25 2022 22:08:42 GMT-0700 (PDT) (index.html, line 154) [Log] DEBUG:Retrieved 6 points at Tue Oct 25 2022 22:08:42 GMT-0700 (PDT) (index.html, line 154) [Log] DEBUG:Retrieved 28 points at Tue Oct 25 2022 22:08:42 GMT-0700 (PDT) (index.html, line 154) ... DEBUG:About to pull location data for range Wed Oct 19 2022 20:56:45 GMT-0700 -> Wed Oct 19 2022 21:09:41 GMT-0700 DEBUG:About to pull location data for range Wed Oct 19 2022 17:33:27 GMT-0700 -> Wed Oct 19 2022 17:46:04 GMT-0700 DEBUG:About to pull location data for range Wed Oct 19 2022 15:01:10 GMT-0700 -> Wed Oct 19 2022 15:18:25 GMT-0700 ```
|
mapLimiter investigation: |
`getDisplayName` is now an abomination unto good programming taste.
It takes two inputs: one which is a "mode" and one which an "obj"
Depending on the mode, it retrieves the appropriate field from the object,
calls nominatim, and then puts the values back into the object.
This is really ugly because:
- we need a switch statement for each object type in this function, thus
breaking modularity and leading to weird contortions (as in the infinite
scroll) if we wanted to support a new type of object that read and wrote to
different places
- we needed two callback functions to process the nominatim result, one to set
the field for everything other than the ctrip end place and the other for
just the ctrip end place
With the new code, we simply refactor to a promisifed function that takes a
location object and returns the matching name. We change all existing call
sites to extract the location correctly, and with `then` to set the value back
correctly.
Testing done:
values read properly in infinite scroll
```
[phonegap] [console.log] 22:48:45 GMT-0700 (PDT) Getting display name for [object Object]
[phonegap] [console.log] 22:48:51 GMT-0700 (PDT)while reading data from nominatim, status = 200 data =
[phonegap] [console.log] 22:48:51 GMT-0700 (PDT)got response, setting display name to ...
```
values read properly in diary
```
[Log] Don't have display name for start place, going to query nominatim
[Log] 22:52:43 GMT-0700 (PDT) Getting display name for – {type: "Point", coordinates: [-122.08652898438098, 37.39099341901742]}
[Log] Don't have display name for end place, going to query nominatim
[Log] 22:52:43 GMT-0700 (PDT) Getting display name for – {type: "Point", coordinates: [-122.08532730526939, 37.38950960523626]}
[Log] Don't have display name for start place, going to query nominatim
[Log] 22:52:43 GMT-0700 (PDT) Getting display name for – {type: "Point", coordinates: [-122.08532730526939, 37.38950960523626]}
[Log] Don't have display name for end place, going to query nominatim
[Log] 22:52:43 GMT-0700 (PDT) Getting display name for – {type: "Point", coordinates: [-122.08644288085807, 37.39101601640591]}
[Log] 22:52:49 GMT-0700 (PDT)while reading data from nominatim, status = 200 data =
[Log] 22:52:49 GMT-0700 (PDT)got response, setting display name to South Shoreline Boulevard, Mountain View
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a snapshot before we start the restructuring with web workers.