fix(bug): remove cleaning dir from abstract tasks

ash-thakur-rh · ash-thakur-rh · commit 1e0cca314baa · 2025-12-05T11:35:53.000+05:30
diff --git a/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java b/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java
@@ -221,10 +221,7 @@ private File[] gradleFilterFiles(File[] resourceFiles) throws IOException {
       return new File[0];
     }
     final File outDir = kubernetesExtension.getWorkDirectoryOrDefault();
-    // Clean the working directory before processing to avoid merging with stale files
-    if (outDir.exists()) {
-      FileUtils.cleanDirectory(outDir);
-    } else if (!outDir.mkdirs()) {
+    if (!outDir.exists() && !outDir.mkdirs()) {
       throw new IOException("Cannot create working dir " + outDir);
     }
     return getFiles(resourceFiles, outDir);
diff --git a/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractJKubeMojo.java b/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/AbstractJKubeMojo.java
@@ -278,10 +278,7 @@ private File[] mavenFilterFiles(File[] resourceFiles, File outDir) throws IOExce
         if (resourceFiles == null) {
             return new File[0];
         }
-        // Clean the working directory before processing to avoid merging with stale files
-        if (outDir.exists()) {
-            FileUtils.cleanDirectory(outDir);
-        } else if (!outDir.mkdirs()) {
+        if (!outDir.exists() && !outDir.mkdirs()) {
             throw new IOException("Cannot create working dir " + outDir);
         }
         return getFiles(resourceFiles, outDir);

Original file line number	Diff line number	Diff line change
`@@ -221,10 +221,7 @@ private File[] gradleFilterFiles(File[] resourceFiles) throws IOException {`
`221`	`221`	`return new File[0];`
`222`	`222`	`}`
`223`	`223`	`final File outDir = kubernetesExtension.getWorkDirectoryOrDefault();`
`224`		`- // Clean the working directory before processing to avoid merging with stale files`
`225`		`- if (outDir.exists()) {`
`226`		`- FileUtils.cleanDirectory(outDir);`
`227`		`- } else if (!outDir.mkdirs()) {`
	`224`	`+ if (!outDir.exists() && !outDir.mkdirs()) {`
`228`	`225`	`throw new IOException("Cannot create working dir " + outDir);`
`229`	`226`	`}`
`230`	`227`	`return getFiles(resourceFiles, outDir);`
Original file line number	Diff line number	Diff line change
`@@ -278,10 +278,7 @@ private File[] mavenFilterFiles(File[] resourceFiles, File outDir) throws IOExce`
`278`	`278`	`if (resourceFiles == null) {`
`279`	`279`	`return new File[0];`
`280`	`280`	`}`
`281`		`- // Clean the working directory before processing to avoid merging with stale files`
`282`		`- if (outDir.exists()) {`
`283`		`- FileUtils.cleanDirectory(outDir);`
`284`		`- } else if (!outDir.mkdirs()) {`
	`281`	`+ if (!outDir.exists() && !outDir.mkdirs()) {`
`285`	`282`	`throw new IOException("Cannot create working dir " + outDir);`
`286`	`283`	`}`
`287`	`284`	`return getFiles(resourceFiles, outDir);`