make genearal evaluator 2nd arg optional

update tests and some example usages that were passing an empty arg
in those cases

Author: montymxb

packages/langium-ai-mcp/src/mcp-server.ts

@@ -34,7 +34,7 @@ server.registerTool(
 export const langiumEvaluator = new LangiumEvaluator(createLangiumGrammarServices(NodeFileSystem).grammar);
 
 export async function validateLangiumCode(code: string): Promise<string | undefined> {
-    const evalResult = await langiumEvaluator.evaluate(code, '');
+    const evalResult = await langiumEvaluator.evaluate(code);
     if (evalResult.data) {
         const langiumData = evalResult.data;
         if (langiumData.diagnostics.length > 0) {

packages/langium-ai-tools/src/evaluator/document-evaluator.ts

@@ -30,11 +30,11 @@ export abstract class AbstractDocumentEvaluator<
      * Validate an agent response as if it's a langium program. If we can parse it, we attempt to validate it.
      *
      * @param input The input to compare
-     * @param expected_response Th expected response to compare against (unused in this evaluator)
-     * @param fileExtension The extension of the language to apply explicitly,
+     * @param expected_response Optional expected response to compare against (unused in this evaluator)
+     * @param fileExtension Optional extension of the language to apply explicitly,
      *  otherwise the first one that's registered will be applied from the services
      */
-    async evaluate(input: string, _expected_response: string, fileExtension?: string): Promise<EvaluatorResult<RD>> {
+    async evaluate(input: string, _expected_response?: string, fileExtension?: string): Promise<EvaluatorResult<RD>> {
         if (input.includes('```')) {
             // take the first code block instead, if present (assuming it's a langium grammar)
             const codeBlock = input.split(/```[a-z-]*/)[1];

packages/langium-ai-tools/src/evaluator/evaluator.ts

@@ -219,10 +219,10 @@ export function loadLastResults(dir: string, take?: number): EvaluatorResult[] {
  */
 export abstract class Evaluator {
     /**
-     * Run an evaluation over some response and compare with an expected one.
+     * Run an evaluation over some response, possibly compares with an expected one if provided
      * Produces a complete evaluator result (name, metadata & data).
      */
-    abstract evaluate(response: string, expected_response: string): Promise<EvaluatorResult>;
+    abstract evaluate(response: string, expected_response?: string): Promise<EvaluatorResult>;
 }
 
 export function mergeEvaluators(...evaluators: Evaluator[]): Evaluator {

packages/langium-ai-tools/tests/evaluator.test.ts

@@ -12,6 +12,7 @@ import {
     mergeEvaluators,
 } from '../src/evaluator/evaluator.js';
 import { LangiumEvaluator } from '../src/evaluator/langium-evaluator.js';
+import { LangiumServices } from 'langium/lsp';
 
 // create test services using the same domain model grammar as document-analyzer tests
 const domainModelServices = await createServicesForGrammar({
@@ -338,7 +339,7 @@ describe('Evaluator Utility Functions', () => {
 });
 
 describe('LangiumEvaluator', () => {
-    let evaluator: LangiumEvaluator;
+    let evaluator: LangiumEvaluator<LangiumServices>;
 
     beforeEach(() => {
         // create a fresh evaluator instance before each test to ensure clean state