refactor: update documentation about generating JS examples #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update the JS output accordingly also
|
Mhh, the failing "coding style check" seems to have something to do with my local setup. See also #1349 |
relu91
reviewed
Feb 12, 2025
| @@ -13,6 +13,7 @@ | |||
| * | |||
| * SPDX-License-Identifier: EPL-2.0 OR W3C-20150513 | |||
| ********************************************************************************/ | |||
| Object.defineProperty(exports, "__esModule", { value: true }); | |||
There was a problem hiding this comment.
This should not be there (according to the tests that I did in the past), I'll double-check locally to understand why it generates this line now.
| /******************************************************************************** | ||
| * Copyright (c) 2022 Contributors to the Eclipse Foundation | ||
| * Copyright (c) 2021 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
These license changes are ok? should we maybe update the ones coming from TS ? are they good?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the JS output accordingly also
fixes #1347