Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of (re-)generating large SGraphs #254

Open
mlange05 opened this issue Mar 20, 2024 · 0 comments
Open

Performance of (re-)generating large SGraphs #254

mlange05 opened this issue Mar 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mlange05
Copy link
Collaborator

With the new Scheduler (PR #213) approaching completion, one of the remaining issues flagged was the performance of building and re-building large SGraph objects, eg. for EC-physics. As a result we reverted to caching the SGraph and only rebuilding it when needed (after discovery and parsing). This issue is to track the necessary performance improvements needed to re-enable fast on-the-fly re-builds.

As a note, a quick initial investigation showed that some of the parser-class caching in make_complete is not quite working as intended yet, but a "quick fix" had severe knock-on effects. Moreover, even with this, there is probably still a significant amount of time spend using FindNodes to (re-)define the dependencies for each SGraph item, causing re-builds to do many traversals per rebuild, which could be improved.

@mlange05 mlange05 added the enhancement New feature or request label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants