Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump 11.0.0 #872

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Version bump 11.0.0 #872

merged 3 commits into from
Mar 18, 2025

Conversation

d4r1091
Copy link
Member

@d4r1091 d4r1091 commented Mar 17, 2025

Triggers release 11.0.0

@d4r1091 d4r1091 requested a review from a team March 17, 2025 16:03
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Regex Filter

Verify that the new branch filter regex correctly targets the intended main branches without unintentionally matching other branch names.

- /^.*main.*/

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Refine branch regexp

If this regex is intended to exclusively match the main branch, use a more precise
pattern like /^main$/ to avoid unintended matches.

.circleci/config.yml [112]

-- /^.*main.*/
+- /^main$/
Suggestion importance[1-10]: 5

__

Why: The suggestion proposes a more precise regex for matching the main branch, which might be overly strict if intentional patterns were used. The proposed change is sensible but depends on the intended behavior.

Low
Possible issue
Validate merge test branches

Verify that removing extra branch filters does not prevent critical tests from
running on feature branches if they are needed.

.github/workflows/merge_tests.yml [5]

-branches: [main]
+branches: [main]  # confirm branch filtering is intentional
Suggestion importance[1-10]: 3

__

Why: The suggestion prompts verification that removing extra branch filters won’t affect testing, but it does not mandate a change. Its impact is limited and it is more advisory than corrective.

Low
Confirm swift lint triggers

Ensure that limiting the lint workflow to only the main branch does not omit
necessary CI checks on other active branches.

.github/workflows/swift_lint.yml [4]

-branches: [main]
+branches: [main]  # verify if additional branches require lint tests
Suggestion importance[1-10]: 3

__

Why: This suggestion advises checking if restricting the lint workflow only to the main branch is correct, serving as a caution rather than a critical bug fix, and thus holds minimal impact.

Low

lucaschifino
lucaschifino previously approved these changes Mar 17, 2025
Copy link
Collaborator

@lucaschifino lucaschifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@d4r1091
Copy link
Member Author

d4r1091 commented Mar 18, 2025

@lucaschifino can I ask for another thumbsup pretty please? 🙏

@d4r1091 d4r1091 requested a review from lucaschifino March 18, 2025 13:46
Copy link
Collaborator

@lucaschifino lucaschifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 1️⃣ 1️⃣ 🆙

@d4r1091 d4r1091 merged commit f8b75d6 into main Mar 18, 2025
4 checks passed
@d4r1091 d4r1091 deleted the dc-version-bump-11.0.0 branch March 18, 2025 16:19
d4r1091 added a commit that referenced this pull request Mar 18, 2025
d4r1091 added a commit that referenced this pull request Mar 18, 2025
d4r1091 added a commit that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants