Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For config with only two possible values, set the non-default value when that config is enabled #329

Closed
raddevon opened this issue Feb 23, 2024 · 0 comments · Fixed by #330
Labels
enhancement New feature or request

Comments

@raddevon
Copy link

This is a confusion I've experienced in the past, and it was recently called out in #317. Changing a boolean configuration value to the non-default value currently requires two steps: enabling the configuration and then setting the value. Since there are only two values, it seems like this UI could be simplified as a toggle that toggles the value directly without also forcing a user to turn that config on.

allow_user_specified_id in the screenshot below is a good example:
CleanShot 2024-02-23 at 14 36 01@2x

It's easy to miss that merely toggling on the toggle switch next to the config variable name has no actual effect since the default value is still set. The user must toggle the switch and also change the value. It makes sense in the context of a configuration with a string value or even an enum with multiple selections, but it's easier to miss on these boolean values.

@raddevon raddevon added the enhancement New feature or request label Feb 23, 2024
@jaclarke jaclarke linked a pull request Feb 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant