Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out better way to handle status codes for network errors #1191

Open
Mr0grog opened this issue Feb 6, 2025 · 0 comments
Open

Figure out better way to handle status codes for network errors #1191

Mr0grog opened this issue Feb 6, 2025 · 0 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Feb 6, 2025

In #1184, I added support for recording versions with network errors (instead of valid HTTP responses), but wound up leaving status as nil in that case. I’d originally planned to set it to 0 as a clear indicator that there was no status code (since we have lots of records of unknown status code from older sources). But we‘ve got some validations to keep them in the standard 100–599 range, and I’m not sure what other code might be expecting these to always be valid.

This issue also caused me to treat network errors as 404 when calculating the page’s overall status, which works, but is definitely not ideal.

Needs some thinking as to what (if anything) should be done here.

@Mr0grog Mr0grog moved this to Inbox in Web Monitoring Feb 17, 2025
@Mr0grog Mr0grog moved this from Inbox to Backlog in Web Monitoring Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant