Embed not visible in toolbox

[vsvanshi]

Tried to include the embed plugin in toolbox, Everthing is working without errors, but its not visible in the toolbox.

[TMiller00]

The toolbox static getter appears to be missing

[dellow]

Yep same here. Not seeing in toolbox.

[gohabereg]

Hey there!

Embed is inserted to the page when you paste link to the resource into the paragraph block. There is no icon in toolbox because tool doesn't have UI for "empty" case.

[dellow]

Oh sweet! It works. My bad I didn't really notice this in the description.

[gohabereg]

Will add a note about that into README

[dellow]

It's sort of in there already. I think it's human nature thing because pretty much all the other plugins have a toolbox icon and other editors tend to have an icon, you don't expect this to be different but it works great.

I imagine most people are not reading the description they just want to get this cool tool installed.

Really great work on all of this by the way.

[zhkuskov]

Please, add icon to toolbox

[silverark]

Doh, I just tripped over this too. Must read the docs.... must read the docs.

[nikitadesign]

Посмотрел ссылку на документацию, но к сожалению, не понятно как установить иконку. Можно привести пример, того как это сделать?

[neSpecc]

Посмотрел ссылку на документацию, но к сожалению, не понятно как установить иконку. Можно привести пример, того как это сделать?

можно форкнуть плагин, добавить в метод render какой-то интерфейс, который будет отображаться по клику на иконку, затем уже определить иконку с помощью свойства toolbox.icon.

[darius00klokj]

Hi, i was able to embed youtube by placing the URL, but soundcloud is not supported. So when i try pasting the embed code provided by SC, which uses an iframe, it does not allow me. Embed should only remove iframe when the src is supported right?

[huevoncito]

@gohabereg This still doesn't work for me for some reason. When I paste a youtube link into the paragraph text it saves as normal text (i.e. { type: "paragraph", data: { text: "https://youtube.com/watch?...." } }

I notice the same thing happens in the demo ( although the demo outputs a <a> elem on paste, whereas my version just shows text. )

Am I missing something?

Thanks again for the fantastic work on this editor and the plugin system. It's great stuff.

[tom-byrom]

No icon is a UX nightmare!! Cannot understand why it's not there.

The people using this are likely users on the front end, who aren't expected to read documentation on how to use, heck they wont even know what they are using apart from nice front end form.

I think, as someone above states the first place they will look to embed something is in the toolbar where everything else is? Maybe a nice box to paste a link would suffice?

I think the fact that code literate people struggle to realise this tells you that normal users would suffer also....

[sosie-js]

In fact what it is missing it a static toolbar always shown for embed inline or block injections, let's say it is a menubar with item buttons to inject embed blocks. This is not handled by the actual toolbar because the actual toolbar for inline stuff is shown and applies on text selection. Then the request is similar to issue insert() embed programmatically #16 . I replied there.