New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #1

Open

ghostdogpr opened this issue May 13, 2019 · 1 comment

ghostdogpr commented May 13, 2019

Thanks for sharing realistic examples of ZIO usage!

I have a couple suggestions:

SQSClient.instantiate calls AWS API which could throw an exception, so it would be better to wrap this code inside Task { }
in Main, the whole ZIO.environment[AppEnvironment].flatMap { _ => seems unnecessary, since you're not using the environment. messageSentConsumer already has the constraint of providing an AppEnvironment so you don't need to add this.

The text was updated successfully, but these errors were encountered:

Owner

edvmorango commented May 13, 2019

Hey @ghostdogpr, thank you for the feedback. I think your suggestions amazing, I will apply them soon I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment