Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional array keys in PHPDocs #1426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix optional array keys in PHPDocs #1426

wants to merge 1 commit into from

Conversation

AnnaNtagiou
Copy link
Contributor

This fixes #1424 in Indices and ClientEndpointsTrait

@AnnaNtagiou AnnaNtagiou marked this pull request as ready for review February 20, 2025 12:06
@AnnaNtagiou AnnaNtagiou requested a review from a team as a code owner February 20, 2025 12:06
@AJenbo
Copy link

AJenbo commented Feb 20, 2025 •
edited
Loading

Nice work, hopefully we can get this merged soon so we can start on correcting all the invalid types.

Merging this will also address most of the issues reported by PHPStan 2

@AJenbo AJenbo mentioned this pull request Feb 20, 2025
Open
This was referenced Feb 22, 2025
Closed
Open
@AnnaNtagiou
Copy link
Contributor Author

@ezimuel Could you please approve the workflow?

@AnnaNtagiou AnnaNtagiou mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJenbo AJenbo AJenbo approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid PHPDocs - optional array keys
2 participants
@AnnaNtagiou @AJenbo