Fix cyclic dependency between clients and sub clients

While the Python GC can handle those dependencies, it can cause latency spikes
when .option() is used for each query, which causes a lot of clients to be
garbage collected.

Author: pquentin

elasticsearch/_async/client/_base.py

@@ -209,7 +209,7 @@ def _default_sniffed_node_callback(
 )
 
 
-class BaseClient:
+class TransportClient:
     def __init__(self, _transport: AsyncTransport) -> None:
         self._transport = _transport
         self._client_meta: Union[DefaultType, Tuple[Tuple[str, str], ...]] = DEFAULT
@@ -376,7 +376,12 @@ def mimetype_header_to_compat(header: str) -> None:
         return response
 
 
-class NamespacedClient(BaseClient):
+class BaseClient(TransportClient):
+    def __init__(self, _transport: AsyncTransport) -> None:
+        super().__init__(_transport)
+
+
+class NamespacedClient(TransportClient):
     def __init__(self, client: "BaseClient") -> None:
         self._client = client
         super().__init__(self._client.transport)

elasticsearch/_sync/client/_base.py

@@ -209,7 +209,7 @@ def _default_sniffed_node_callback(
 )
 
 
-class BaseClient:
+class TransportClient:
     def __init__(self, _transport: Transport) -> None:
         self._transport = _transport
         self._client_meta: Union[DefaultType, Tuple[Tuple[str, str], ...]] = DEFAULT
@@ -376,7 +376,12 @@ def mimetype_header_to_compat(header: str) -> None:
         return response
 
 
-class NamespacedClient(BaseClient):
+class BaseClient(TransportClient):
+    def __init__(self, _transport: Transport) -> None:
+        super().__init__(_transport)
+
+
+class NamespacedClient(TransportClient):
     def __init__(self, client: "BaseClient") -> None:
         self._client = client
         super().__init__(self._client.transport)