Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 19 #1108

Open
craquet opened this issue Feb 7, 2025 · 3 comments
Open

Support React 19 #1108

craquet opened this issue Feb 7, 2025 · 3 comments
Labels

Comments

@craquet
Copy link

craquet commented Feb 7, 2025

Is your feature request related to a problem? Please describe.
Trying to install the react search-ui packages with react 19 fails due to mismatching peer dependencies. The search-ui packages declare react < 19 as peer dependencies. Installing is still possible via the --force flag, but could cause issues for example in the CI, where we don't want to append --force everywhere

Describe the solution you'd like
Change the peer dependencies of search-ui packages (that use react) to allow usage with react 19. See the upgrade guide, some changes might be required.

Describe alternatives you've considered
Forcing npm install with --force or --legacy-peer-deps works as a workaround but is not recommended by npm.

Additional context
I've tested my application with search-ui and react 19 and it works just fine. Might not apply to other use cases though.

@craquet craquet added the feature label Feb 7, 2025
@turboRails
Copy link

I think this is the status from 2022.

Elasticsearch connector for Search UI is currently in technical preview status. It is not ready for production use.[

On the other hand it was written

Workplace Search connector for Search UI is deprecated and will no longer be supported. Please migrate to Elasticsearch Connector for continued support.

I guess we are going to stick to node Client and write own components.

@fvanderwielen
Copy link

plus one on this one, we are running into this issue on our project as well.

A similar version and peerDependency bump like last year would be highly appreciated!

@KoenBrouwer
Copy link

KoenBrouwer commented Feb 21, 2025

Yep, we're facing the same issue. This is the only one that's blocking our update to React 19.
Sidenote: we've been running on 18.3 since april and have had no issues so far. My 2 cents would be that it's just a matter of bumping to allow 19. Would be greatly appreciated if this could be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants