Consider an opt-in flag to treat PKG_NOT_ON_DISK & PKG_NOT_FOUND fatal

[t3chguy]

As per title, I don't see why a build is successful if some dependencies are missing. Opt-in or forced but with a config flag to "ignoreMissingDependency": ["x"] would be nice

My temporary (yet untested) workaround:

// Treat certain warnings as a fatal error
const FATAL_WARNINGS = [LogMessageByKey.PKG_NOT_ON_DISK, LogMessageByKey.PKG_NOT_FOUND];
// Otherwise we just burn time running the tests for no reason.
const prevTransform = log.messageTransformer;
log.messageTransformer = (message, level) => {
    if (level === "warn" && FATAL_WARNINGS.some((w) => message.startsWith(w))) {
        throw new Error(`electron-builder: ${message}`);
    }
    return prevTransform?.(message, level) ?? message;
};

[mmaietta]

I'm in favor of this change. I think originally it was a warning to avoid false flags of platform+arch specific packages that weren't installed on the host device by-default, but IIRC, we now have a different LogMessageByKey for that heuristic.

I like the idea of explicit specification of ignored dependencies. Perhaps we have it as a boolean | string[] to allow a "blanket"/shotgun approach to be enabled as well (for initial debugging purposes). For the true case, we would wait until all dependencies missing are detected, then output the final list. Thoughts?

[t3chguy]

I think it's more right to output the whole list. I mean it is only printed after it has completed collection so that looks like a sane place to hook in. It won't affect runtime significantly and saves an entire extra runner spinning up to test a known bad build

[mmaietta]

@t3chguy would you be willing to take a look at #10073 when you have a chance? Curious on your thoughts.