refactor: rename isAuthorizedUser to isAuthorizedElectronRepoUser

Address review feedback from dsanders11: the authorization check is now
hardcoded to evaluate permissions against electron/electron, so the
generic name was misleading. Rename it to reflect that it specifically
authorizes users against the electron/electron repository.

No behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LL7ZzLv5mo4Wqf3BiWk8HB

Author: claude

src/index.ts

@@ -5,7 +5,7 @@ import { handleChromiumCheck } from './chromium-handler.js';
 import { handleBuildImagesCheck } from './build-images-handler.js';
 import { handleBuildImagesChromiumDepsCheck } from './build-images-chromium-deps-handler.js';
 import { REPOS, ROLL_TARGETS } from './constants.js';
-import { isAuthorizedUser } from './utils/is-authorized-user.js';
+import { isAuthorizedElectronRepoUser } from './utils/is-authorized-user.js';
 
 const handler = (robot: Probot) => {
   robot.on('pull_request.closed', async (context) => {
@@ -83,7 +83,7 @@ const handler = (robot: Probot) => {
     }
 
     // Allow all users with push access to run commands
-    if (!(await isAuthorizedUser(context, comment.user.login))) {
+    if (!(await isAuthorizedElectronRepoUser(context, comment.user.login))) {
       d(`@${comment.user.login} is not authorized to run roller commands - stopping`);
       await context.octokit.rest.issues.createComment(
         context.repo({

src/utils/is-authorized-user.ts

@@ -2,7 +2,7 @@ import type { Context } from 'probot';
 
 import { REPOS } from '../constants.js';
 
-export async function isAuthorizedUser(
+export async function isAuthorizedElectronRepoUser(
   context: Context<'issue_comment.created'>,
   username: string,
 ) {

tests/index.spec.ts

@@ -5,7 +5,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import handler from '../src/index.js';
 import { handleChromiumCheck } from '../src/chromium-handler.js';
 import { handleNodeCheck } from '../src/node-handler.js';
-import { isAuthorizedUser } from '../src/utils/is-authorized-user.js';
+import { isAuthorizedElectronRepoUser } from '../src/utils/is-authorized-user.js';
 
 import issueCommentRollCreatedEvent from './fixtures/issue_comment_roll.created.json' with { type: 'json' };
 
@@ -44,7 +44,7 @@ describe('roller', () => {
     });
 
     it('rolls Chromium when an authorized user comments /roll main', async () => {
-      vi.mocked(isAuthorizedUser).mockResolvedValue(true);
+      vi.mocked(isAuthorizedElectronRepoUser).mockResolvedValue(true);
 
       nock(GH_API)
         .post('/repos/electron/electron/issues/0/comments', ({ body }) => {
@@ -59,7 +59,7 @@ describe('roller', () => {
     });
 
     it('rolls Node.js when an authorized user comments /roll main', async () => {
-      vi.mocked(isAuthorizedUser).mockResolvedValue(true);
+      vi.mocked(isAuthorizedElectronRepoUser).mockResolvedValue(true);
 
       nock(GH_API)
         .post('/repos/electron/electron/issues/0/comments', ({ body }) => {
@@ -76,20 +76,20 @@ describe('roller', () => {
     });
 
     it('ignores roll commands from repositories other than electron/electron', async () => {
-      vi.mocked(isAuthorizedUser).mockResolvedValue(true);
+      vi.mocked(isAuthorizedElectronRepoUser).mockResolvedValue(true);
 
       const event = JSON.parse(JSON.stringify(issueCommentRollCreatedEvent));
       event.payload.repository.name = 'other-repo';
       event.payload.repository.full_name = 'electron/other-repo';
       await probot.receive(event as Parameters<typeof probot.receive>[0]);
 
-      expect(isAuthorizedUser).not.toHaveBeenCalled();
+      expect(isAuthorizedElectronRepoUser).not.toHaveBeenCalled();
       expect(handleChromiumCheck).not.toHaveBeenCalled();
       expect(handleNodeCheck).not.toHaveBeenCalled();
     });
 
     it('blocks unauthorized users from triggering a roll', async () => {
-      vi.mocked(isAuthorizedUser).mockResolvedValue(false);
+      vi.mocked(isAuthorizedElectronRepoUser).mockResolvedValue(false);
 
       nock(GH_API)
         .post('/repos/electron/electron/issues/0/comments', ({ body }) => {