Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message when file changes on disk to include moving or renaming #677

Closed
eppixx opened this issue May 29, 2019 · 6 comments
Closed
Labels
Priority: Low On the radar, but not the most urgent thing

Comments

@eppixx
Copy link

eppixx commented May 29, 2019

Case:

  1. open a text file
  2. change file name
  3. Code informs the file has been deleted

Improvement suggestion:

  • change the message to "file has been deleted, moved or renamed"
    or
  • notice the file has been renamed and ask if code should open the renamed file
@cassidyjames
Copy link
Contributor

The first suggestion sounds easy enough to implement. The latter sounds more ideal but more involved. 😄 I'll get a PR together for the first though!

@jeremypw jeremypw added the Priority: Low On the radar, but not the most urgent thing label Dec 23, 2024
jeremypw pushed a commit that referenced this issue Jan 9, 2025
Changed the details reflected to the user as described in #677
@ryonakano
Copy link
Member

notice the file has been renamed and ask if code should open the renamed file

This might be possible using GLib.File.monitor() with the GLib.FileMonitorFlags.WATCH_MOVES flag and connecting to the GLib.FileMonitor.changed signal.

But I don't think this is necessary and thus I think we can close this issue as fixed in #1505.

@jeremypw
Copy link
Collaborator

Probably best to split this into two issues as the original description is vague. The first part is fixed and the second is still open and potentially fixable.

@jeremypw jeremypw changed the title improve handling file changes on disk Improve message when file changes on disk to include moving or renaming Jan 11, 2025
@jeremypw
Copy link
Collaborator

jeremypw commented Jan 11, 2025

Reduced scope of this issue. New issue created about re-opening a renamed or moved document. Closing this issue as fixed by #1505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low On the radar, but not the most urgent thing
Projects
None yet
Development

No branches or pull requests

5 participants
@cassidyjames @eppixx @jeremypw @ryonakano and others