Skip to content

Commit 4682bf0

Browse files
committed
minor
1 parent 58fb101 commit 4682bf0

File tree

1 file changed

+33
-32
lines changed

1 file changed

+33
-32
lines changed

.github/workflows/code_quality.yaml

+33-32
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,38 @@ jobs:
2020
# - name: Set up environment
2121
# uses: ./.github/actions/setup/poetry
2222
# with:
23-
# os: ${{ job.os }}
24-
# python-version: '3.13.0'
25-
# poetry-install-options: "--only=code_quality --no-root"
26-
# poetry-export-options: "--only=code_quality"
27-
28-
# - name: Check code style
29-
# run: poetry run ruff format --check
30-
31-
hadolint:
23+
# os: ${{ job.os }}
24+
# python-version: '3.13.0'
25+
# poetry-install-options: "--only=code_quality --no-root"
26+
# poetry-export-options: "--only=code_quality"
27+
28+
# - name: Check code style
29+
# run: poetry run ruff format --check
30+
31+
# - name: Checkout code
32+
# uses: actions/checkout@v4
33+
34+
# # - name: Create output directory
35+
# # run: |
36+
# # mkdir -p "$(dirname "hadolint-results-${{ matrix.dockerfile }}.sarif")"
37+
38+
# - name: Run Hadolint
39+
# uses: hadolint/[email protected]
40+
# with:
41+
# dockerfile: ${{ matrix.dockerfile }}
42+
# format: sarif
43+
# output-file: hadolint-results-${{ matrix.dockerfile }}.sarif
44+
# no-fail: true
45+
# ignore: DL3008,DL3013
46+
47+
# - name: Upload hadolint results to github security tab
48+
# uses: github/codeql-action/upload-sarif@v3
49+
# if: always()
50+
# with:
51+
# sarif_file: hadolint-results-${{ matrix.dockerfile }}.sarif
52+
# wait-for-processing: true
53+
54+
hadolint:
3255
name: Dockerfile Lint
3356
runs-on: ubuntu-latest
3457
permissions:
@@ -41,34 +64,12 @@ jobs:
4164
- jupyterhub/hub/hub.Dockerfile
4265
- jupyterhub/notebook/notebook.Dockerfile
4366
steps:
44-
# - name: Checkout code
45-
# uses: actions/checkout@v4
46-
47-
# # - name: Create output directory
48-
# # run: |
49-
# # mkdir -p "$(dirname "hadolint-results-${{ matrix.dockerfile }}.sarif")"
50-
51-
# - name: Run Hadolint
52-
# uses: hadolint/[email protected]
53-
# with:
54-
# dockerfile: ${{ matrix.dockerfile }}
55-
# format: sarif
56-
# output-file: hadolint-results-${{ matrix.dockerfile }}.sarif
57-
# no-fail: true
58-
# ignore: DL3008,DL3013
59-
60-
# - name: Upload hadolint results to github security tab
61-
# uses: github/codeql-action/upload-sarif@v3
62-
# if: always()
63-
# with:
64-
# sarif_file: hadolint-results-${{ matrix.dockerfile }}.sarif
65-
# wait-for-processing: true
6667
- name: Checkout code
6768
uses: actions/checkout@v4
6869

6970
- name: Sanitize Dockerfile name
7071
id: sanitize_name
71-
run: echo "::set-output name=safe_name::${{ matrix.dockerfile//\//_ }}"
72+
run: echo "safe_name=${{ matrix.dockerfile//\//_ }}" >> $GITHUB_OUTPUT
7273

7374
- name: Run Hadolint
7475
uses: hadolint/[email protected]

0 commit comments

Comments
 (0)