Update Elixir CI workflow#292
Closed
iruoy wants to merge 1 commit into
Closed
Conversation
iamvery
reviewed
Sep 10, 2024
Collaborator
iamvery
left a comment
iamvery
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Would you mind adding some notes to explain the changes?
| with: | ||
| elixir-version: '1.12.3' # Define the elixir version [required] | ||
| otp-version: '24.1' # Define the OTP version [required] | ||
| elixir-version: '1.17' # [Required] Define the Elixir version |
Collaborator
There was a problem hiding this comment.
I believe this was left as a old version to ensure some backwards compatibility with running the Koans on old Elixirs. I'm not sure how important that is presently, but what is your take? Should we consider a build matrix?
Collaborator
There was a problem hiding this comment.
As I think about this, I lean towards limiting CI to a more/most current Elixir release given that folks learning Elixir are likely to be using the latest. I'm not aware of situations where one would be limited to an old release, e.g. some computing limitation on the machine they're learning with. Thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failing tests and supersedes #288