Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after upgrading to latest: Module not found: Error: Can't resolve 'process/browser' #835

Open
hoIIer opened this issue Jun 18, 2023 · 3 comments

Comments

@hoIIer
Copy link

hoIIer commented Jun 18, 2023

Just upgraded to latest and getting the following error:

ERROR in ./node_modules/sinon/pkg/sinon-esm.js 405:74-81
Module not found: Error: Can't resolve 'process/browser' in '/Users/eric/Projects/sqwok/ember-sqwok/node_modules/sinon/pkg'

Any suggestions or ideas?

@elwayman02
Copy link
Owner

What exact versions were you upgrading from and to? What version of sinon are you using?

The esm module is handled by ember-auto-import here: https://github.com/elwayman02/ember-sinon-qunit/blob/master/index.js#L9

There isn't anything more complex going on, but it seems like it's having some issue internal to sinon?

@elwayman02
Copy link
Owner

@hoIIer we've just released v7.4.0 which no longer uses ember-auto-import for bundling. Can you test again to see if it works for you on the latest version?

@RobbieTheWagner
Copy link

@elwayman02 I am seeing this on 7.4.0 as well. We have stuff like this in our app:

      webpack: {
        plugins: [
          new webpack.ProvidePlugin({
            process: 'process/browser',
          }),
        ],

But it seems that this addon is still not able to find this dependency. To note, we are not on embroider yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants