From 59a099853771ef77bc2e99795333ddd232a55777 Mon Sep 17 00:00:00 2001
From: pankaj-awake <mr.georgian4000@gmail.com>
Date: Sun, 17 Oct 2021 20:45:39 +0530
Subject: [PATCH 1/2] Add action onChange on component

---
 addon/components/select-light.hbs |  2 +-
 addon/components/select-light.js  | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/addon/components/select-light.hbs b/addon/components/select-light.hbs
index ac2857b..59a3a15 100644
--- a/addon/components/select-light.hbs
+++ b/addon/components/select-light.hbs
@@ -1,5 +1,5 @@
 <select
-  {{on "change" this.change}}
+  {{on "change" this.onChange}}
   ...attributes>
   {{#if @placeholder}}
     <option value="" selected disabled>
diff --git a/addon/components/select-light.js b/addon/components/select-light.js
index 0dbc609..16e7a54 100644
--- a/addon/components/select-light.js
+++ b/addon/components/select-light.js
@@ -1,5 +1,6 @@
 import Component from '@glimmer/component';
-import { isNone } from '@ember/utils';
+import { isNone, isPresent } from '@ember/utils';
+import { action } from '@ember/object';
 import { deprecate } from '@ember/debug';
 
 const noop = () => {};
@@ -28,4 +29,18 @@ export default class extends Component {
       this.args.options?.[0][this.displayKey],
     ].some(isNone);
   }
+
+  @action
+  onChange(event) {
+    if (isPresent(this.change)) {
+      const { args: { options, valueKey }, change, hasDetailedOptions } = this
+      let selectedOptions = [...event.target.selectedOptions].map(function(option) {
+        return hasDetailedOptions ? options.findBy(valueKey, option.value) : option.value
+      })
+      if (!event.target.multiple) {
+        selectedOptions = selectedOptions[0]
+      }
+      change(selectedOptions, event)
+    }
+  }
 }

From 6d1707afc36f188c67ed7571975e6cb3419a038a Mon Sep 17 00:00:00 2001
From: pankaj-awake <mr.georgian4000@gmail.com>
Date: Sun, 17 Oct 2021 20:46:19 +0530
Subject: [PATCH 2/2] Remove noop usage

---
 addon/components/select-light.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/addon/components/select-light.js b/addon/components/select-light.js
index 16e7a54..e833566 100644
--- a/addon/components/select-light.js
+++ b/addon/components/select-light.js
@@ -3,15 +3,13 @@ import { isNone, isPresent } from '@ember/utils';
 import { action } from '@ember/object';
 import { deprecate } from '@ember/debug';
 
-const noop = () => {};
-
 export default class extends Component {
   constructor() {
     super(...arguments);
 
     this.valueKey = this.args.valueKey ?? 'value';
     this.displayKey = this.args.displayKey ?? 'label';
-    this.change = this.args.onChange ?? this.args.change ?? noop;
+    this.change = this.args.onChange ?? this.args.change;
 
     deprecate(`Triggering @change on <SelectLight /> is deprecated in favor of @onChange due to ember-template-lint's no-passed-in-event-handlers rule`, !this.args.change, {
       id: 'ember-select-light.no-passed-in-event-handlers',