Skip to content

Commit 082d878

Browse files
committed
Revert "add code to support node 8"
This reverts commit 13e645c.
1 parent 1042e15 commit 082d878

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/get-start-and-end-commands.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ const nodeModulesIgnore = `
1919
/node_modules/
2020
`;
2121

22-
// remove when node 8 is dropped
23-
const lastNode8Version = '3.16';
24-
2522
module.exports = function getStartAndEndCommands({
2623
packageJson: { name: projectName },
2724
baseBlueprint,
@@ -50,7 +47,7 @@ module.exports = function getStartAndEndCommands({
5047
// first version that supports blueprints with versions
5148
5249
// https://github.com/ember-cli/ember-cli/pull/8571
53-
startRange = endRange = `>=3.11.0-beta.1 <${lastNode8Version}`;
50+
startRange = endRange = '>=3.11.0-beta.1';
5451
}
5552

5653
return {
@@ -175,7 +172,7 @@ function runEmberRemotely({
175172
let isGlimmer = blueprint.packageName === glimmerPackageName && blueprint.name === glimmerPackageName;
176173

177174
if (isCustomBlueprint || isGlimmer) {
178-
args = [`ember-cli@${lastNode8Version}`, ...args];
175+
args = ['ember-cli', ...args];
179176
// args = ['-p', 'github:ember-cli/ember-cli#cfb9780', 'ember', 'new', projectName, `-dir=${directoryName}, '-sg', -sn', '-b', `${blueprint.packageName}@${blueprint.version}`];
180177
} else {
181178
args = ['-p', `ember-cli@${blueprint.version}`, 'ember', ...args];

test/unit/get-start-and-end-commands-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ describe(_getStartAndEndCommands, function() {
254254
name: blueprint,
255255
version: startVersion
256256
},
257-
packageRange: '>=3.11.0-beta.1 <3.16'
257+
packageRange: '>=3.11.0-beta.1'
258258
},
259259
endOptions: {
260260
baseBlueprint: {
@@ -265,7 +265,7 @@ describe(_getStartAndEndCommands, function() {
265265
name: blueprint,
266266
version: endVersion
267267
},
268-
packageRange: '>=3.11.0-beta.1 <3.16'
268+
packageRange: '>=3.11.0-beta.1'
269269
}
270270
});
271271
});
@@ -335,7 +335,7 @@ describe(_getStartAndEndCommands, function() {
335335

336336
expect(npxStub.args).to.deep.equal([[
337337
[
338-
`${packageName}@3.16`,
338+
packageName,
339339
'new',
340340
projectName,
341341
'-sg',

0 commit comments

Comments
 (0)