[feature/multi-output-luts_parameter-tab] Changes in the parameter table are now also saved in the gate

Author: AriKHaji

plugins/gui/include/gui/selection_details_widget/gate_details_widget/parameter_table_model.h

@@ -25,18 +25,14 @@
 
 #pragma once
 
-#include "hal_core/netlist/parameter.h"
-
 #include <QAbstractTableModel>
 #include <QString>
 #include <QVector>
 
-#include <string>
-#include <unordered_map>
-#include <utility>
-
 namespace hal
 {
+    class Gate;
+
     /**
      * @ingroup utility_widgets-selection_details
      *
@@ -92,11 +88,12 @@ namespace hal
         QVariant headerData(int section, Qt::Orientation orientation, int role) const override;
 
         /**
-         * Fills the table with the given gate parameters (name -> (declaration, value)).
+         * Fills the table with the parameters of the given gate and remembers the gate so that
+         * edits can be written back to it.
          *
-         * @param parameters - The parameters as returned by Gate::get_parameters().
+         * @param gate - The gate whose parameters are displayed.
          */
-        void updateData(const std::unordered_map<std::string, std::pair<Parameter, std::string>>& parameters);
+        void updateData(Gate* gate);
 
         bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) override;
 
@@ -113,5 +110,8 @@ namespace hal
         };
 
         QVector<ParameterRow> mRows;
+
+        // Non-owning pointer to the gate currently displayed; the netlist owns the gate.
+        Gate* mGate = nullptr;
     };
 }

plugins/gui/include/gui/selection_details_widget/gate_details_widget/parameter_table_widget.h

@@ -58,7 +58,7 @@ namespace hal
              *
              * @param gate - The gate.
              */
-            void setGate(Gate* gate);
+            void setGate(Gate* gate) const;
 
     private:
             ParameterTableModel* mParameterTableModel;

plugins/gui/src/selection_details_widget/gate_details_widget/parameter_table_model.cpp

@@ -1,8 +1,10 @@
 #include "gui/selection_details_widget/gate_details_widget/parameter_table_model.h"
 
+#include "hal_core/netlist/gate.h"
 #include "hal_core/utilities/enums.h"
 
 #include <algorithm>
+#include <boost/container/container_fwd.hpp>
 
 namespace hal
 {
@@ -70,12 +72,13 @@ namespace hal
         return QVariant();
     }
 
-    void ParameterTableModel::updateData(const std::unordered_map<std::string, std::pair<Parameter, std::string>>& parameters)
+    void ParameterTableModel::updateData(Gate* gate)
     {
         beginResetModel();
+        mGate = gate;
         mRows.clear();
 
-        for (const auto& [name, declAndValue] : parameters)
+        for (const auto& [name, declAndValue] : gate->get_parameters())
         {
             const Parameter& decl = declAndValue.first;
 
@@ -101,7 +104,22 @@ namespace hal
             return false;
         }
 
-        this->mRows[index.row()].value = value.toString();
+        const std::string name = mRows[index.row()].name.toStdString();
+
+        Result<Parameter> param = this->mGate->get_parameter_declaration(name);
+        if (param.is_error())
+        {
+            return false;
+        }
+
+        Result<std::monostate> result = this->mGate->set_parameter(param.get(), value.toString().toStdString());
+        if (result.is_error())
+        {
+            return false;
+        }
+
+        std::string norm_value = this->mGate->get_parameter_value(name).get();
+        this->mRows[index.row()].value = QString::fromStdString(norm_value);
 
         Q_EMIT dataChanged(index, index);
         return true;

plugins/gui/src/selection_details_widget/gate_details_widget/parameter_table_widget.cpp

@@ -21,12 +21,12 @@ namespace hal
         setItemDelegateForColumn(4, new ParameterValueDelegate(this));
     }
 
-    void ParameterTableWidget::setGate(Gate* gate)
+    void ParameterTableWidget::setGate(Gate* gate) const
     {
         if (gate == nullptr)
             return;
 
-        mParameterTableModel->updateData(gate->get_parameters());
+        mParameterTableModel->updateData(gate);
     }
 }
 

plugins/gui/src/selection_details_widget/gate_details_widget/parameter_value_delegate.cpp

@@ -24,7 +24,7 @@ namespace hal
             }
             case Parameter::Type::Integer: {
                 auto textField = new QLineEdit(parent);
-                textField->setValidator(new QIntValidator(textField));
+                textField->setValidator(new QRegularExpressionValidator(QRegularExpression("-?\\d*"), textField));
                 return textField;
             }
             case Parameter::Type::Float: {