misc cleanup

Author: adraffy

contracts/src/common/IDedicatedResolver.sol

@@ -9,7 +9,7 @@ interface IDedicatedResolver {
     error InvalidEVMAddress(bytes addressBytes);
 
     /// @notice Set address for the coin type.
-    ///         If coin type is EVM, require exactly 0 or 20 bytes.
+    ///         Reverts `InvalidEVMAddress` if coin type is EVM and address is not 0 or 20 bytes.
     /// @param coinType The coin type.
     /// @param addressBytes The address to set.
     function setAddr(uint256 coinType, bytes calldata addressBytes) external;

contracts/test/fixtures/deployV1Fixture.ts

@@ -1,16 +1,13 @@
-import type {
-  DefaultChainType,
-  NetworkConnection,
-} from "hardhat/types/network";
+import type { NetworkConnection } from "hardhat/types/network";
 import { labelhash, namehash } from "viem";
 import { splitName } from "../utils/utils.js";
 import { baseRegistrarImplementationArtifact } from "./ens-contracts/BaseRegistrarImplementation.js";
 import { ensRegistryArtifact } from "./ens-contracts/ENSRegistry.js";
 import { ownedResolverArtifact } from "./ens-contracts/OwnedResolver.js";
 import { universalResolverArtifact } from "./ens-contracts/UniversalResolver.js";
 
-export async function deployV1Fixture(
-  networkConnection: NetworkConnection<DefaultChainType>,
+export async function deployV1Fixture<C extends NetworkConnection>(
+  networkConnection: C,
   enableCcipRead = false,
 ) {
   const publicClient = await networkConnection.viem.getPublicClient({

contracts/test/fixtures/deployV2Fixture.ts

@@ -1,7 +1,4 @@
-import type {
-  DefaultChainType,
-  NetworkConnection,
-} from "hardhat/types/network";
+import type { NetworkConnection } from "hardhat/types/network";
 import {
   type Address,
   encodeFunctionData,
@@ -48,10 +45,10 @@ export const ROLES = {
   OWNER: FLAGS,
   ADMIN: mapFlags(FLAGS, (x) => x << 128n),
   ALL: (1n << 256n) - 1n, // see: EnhancedAccessControl.sol
-} as const;
+} as const satisfies Flags;
 
-export async function deployV2Fixture(
-  networkConnection: NetworkConnection<DefaultChainType>,
+export async function deployV2Fixture<C extends NetworkConnection>(
+  networkConnection: C,
   enableCcipRead = false,
 ) {
   const publicClient = await networkConnection.viem.getPublicClient({
@@ -107,8 +104,6 @@ export async function deployV2Fixture(
   }: {
     owner: Address;
     salt?: bigint;
-    wildcard?: boolean;
-    findResolverAddress?: Address;
   }) {
     const wallet = await networkConnection.viem.getWalletClient(owner);
     const hash = await verifiableFactory.write.deployProxy([

contracts/test/resolver/DedicatedResolver.t.sol

@@ -60,18 +60,16 @@ contract DedicatedResolverTest is Test {
             DedicatedResolver.initialize,
             (owner)
         );
-        vm.startPrank(owner);
         resolver = DedicatedResolver(
             factory.deployProxy(
                 address(resolverImpl),
                 uint256(keccak256(initData)),
                 initData
             )
         );
-        vm.stopPrank();
     }
 
-    function test_owner() external {
+    function test_owner() external view {
         assertEq(resolver.owner(), owner);
     }