Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save resolved upstream address in SNI dynamic forward proxy #37078

Open
santbl opened this issue Nov 9, 2024 · 1 comment
Open

Save resolved upstream address in SNI dynamic forward proxy #37078

santbl opened this issue Nov 9, 2024 · 1 comment
Labels
area/sni_dynamic_forward_proxy enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@santbl
Copy link

santbl commented Nov 9, 2024

Title: Save resolved upstream address in filter state in SNI dynamic forward proxy

Description:
Support saving the resolved upstream address in filter state in SNI dynamic forward proxy
like in dynamic forward proxy. This enables the evaluation of the resolved upstream address
in subsequent filters for security checks.

I have an implementation. Please confirm if the enhancement sounds reasonable.

Relevant Links:
dynamic_forward_proxy already supports save_upstream_address.
Enhancing sni_dynamic_forward_proxy to also support save_upstream_address.

@santbl santbl added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 9, 2024
@yanavlasov yanavlasov added area/sni_dynamic_forward_proxy help wanted Needs help! and removed triage Issue requires triage labels Nov 11, 2024
@santbl
Copy link
Author

santbl commented Nov 11, 2024

I have posted a PR with the enhancement.
Please review: #37099
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sni_dynamic_forward_proxy enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants