Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS does not set config_reload or config_reload_time_ms statistics #38490

Open
isker opened this issue Feb 19, 2025 · 1 comment
Open

CDS does not set config_reload or config_reload_time_ms statistics #38490

isker opened this issue Feb 19, 2025 · 1 comment
Labels

Comments

@isker
Copy link
Contributor

isker commented Feb 19, 2025

This page documents xDS statistics. It seems that each kind of resource supported by xDS must update config_reload and config_reload_time_ms itself, and CDS simply does not do this. I see rds, scoped rds, and vhds doing it. CDS (and others?) are missing. I am concretely aware of CDS missing it, because we use CDS and RDS, and only have these statistics for RDS.

The update_* stats documented on the same page do not have this problem, as they are done centrally for all resources.

@isker isker added bug triage Issue requires triage labels Feb 19, 2025
@adisuissa adisuissa added beginner Good starter issues! area/config_discovery and removed triage Issue requires triage labels Feb 20, 2025
@adisuissa
Copy link
Contributor

Thanks for raising this issue!
Seems this was not added for some of xDS subscriptions.
PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants