Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Chrome browser statistics wrong #66

Closed
mpbraendle opened this issue Oct 1, 2015 · 1 comment
Closed

Google Chrome browser statistics wrong #66

mpbraendle opened this issue Oct 1, 2015 · 1 comment
Labels

Comments

@mpbraendle
Copy link

Due to a faulty match procedure in Browsers.pm, accesses by Google Chrome browser are (practically) not counted, but are attributed to Apple Safari (see http://www.eprints.org/tech.php/20781.html )

There are two possibilities to remedy this:

  • either replace "Apple Safari" by "Safari" in line 20
  • or change line 54 as follows:

    foreach( keys %$BROWSERS_SIGNATURES )

     foreach( sort keys %$BROWSERS_SIGNATURES )
    

The statistics must be recalculated from scratch.

@jesusbagpuss
Copy link
Contributor

See also #87.
The sort fix only works because 'Chrome' is alphabetically before Safari.

Might be worth looking at e.g. https://github.com/ua-parser/ for a more 'proper' solution?
Although I'm not sure whether this overhead is needed (it detects OS, Browser, versions - but thiese could be interesting when looking at stats too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants