Skip to content

Conversation

@Hjaf
Copy link
Contributor

@Hjaf Hjaf commented Nov 6, 2025

Copilot summary:

This pull request updates the development container configuration to simplify setup and improve compatibility, especially for ARM-based hosts. The main changes involve switching from a custom Dockerfile to a prebuilt image, updating dependency installation steps, and improving the docu:start script for better accessibility.

Devcontainer configuration improvements:

  • Replaced the custom .devcontainer/Dockerfile with a direct reference to the prebuilt mcr.microsoft.com/devcontainers/typescript-node:22-bullseye image in .devcontainer/devcontainer.json, removing the need to maintain a separate Dockerfile. [1] [2]
  • Added a postCreateCommand in .devcontainer/devcontainer.json to install additional AMD64 libraries for better compatibility with tools like axe linter on ARM-based hosts (e.g., Apple Silicon Macs).
  • Updated the features section in .devcontainer/devcontainer.json to use the latest Node version and add jq-like utilities via a community feature, while removing redundant Docker and SSHD features.
  • Moved installation of global npm packages (pnpm, gitmoji-cli) from the Dockerfile to the onCreateCommand in .devcontainer/devcontainer.json for a more streamlined setup. [1] [2]

Script accessibility improvement:

  • Modified the docu:start script in package.json to bind the documentation server to 0.0.0.0, making it accessible from outside the container.

@vnys can you confirm that the features I have removed are in fact redundant?
I have tested build and run of the documentation in both codespace and a local devcontainer on my mac.

@Hjaf Hjaf self-assigned this Nov 6, 2025
Copilot AI review requested due to automatic review settings November 6, 2025 11:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the devcontainer configuration by simplifying setup and improving compatibility, particularly for ARM-based development environments like Apple Silicon Macs.

  • Replaces custom Dockerfile with prebuilt Microsoft devcontainer image
  • Adds ARM architecture support for axe linter and other AMD64-dependent tools
  • Makes documentation server accessible from outside containers by binding to 0.0.0.0

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
.devcontainer/devcontainer.json Migrated from custom Dockerfile to prebuilt image, added ARM support via postCreateCommand, updated features to include Node 22.12.0 and jq utilities, moved global npm package installation to onCreateCommand
.devcontainer/Dockerfile Removed in favor of prebuilt image approach
package.json Added --host 0.0.0.0 flag to docu:start script to enable external container access
.gitignore Added .pnpm-store directory to ignore list for cleaner repository

pomfrida
pomfrida previously approved these changes Nov 7, 2025
Copy link
Collaborator

@pomfrida pomfrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copilot AI review requested due to automatic review settings December 8, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

"docu:start": "pnpm --filter ./apps/design-system-docs run start",
"docu:build": "pnpm run extract-prerequisites && pnpm --filter ./apps/design-system-docs run build",
"docu:serve": "pnpm --filter ./apps/design-system-docs run serve",
"docu:start": "pnpm --filter ./apps/design-system-docs run start --host 0.0.0.0",
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docu:serve script is being removed but it's still documented in apps/design-system-docs/README.md (line 43). Either the script should be kept or the documentation should be updated to remove references to it.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root README.md refers to versions in the root package.json, not apps/design-system-docs/package.json. The apps/design-system-docs/README.md is specific to its local package.json.

Copilot AI review requested due to automatic review settings December 8, 2025 13:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

"docu:start": "pnpm --filter ./apps/design-system-docs run start",
"docu:build": "pnpm run extract-prerequisites && pnpm --filter ./apps/design-system-docs run build",
"docu:serve": "pnpm --filter ./apps/design-system-docs run serve",
"docu:start": "pnpm --filter ./apps/design-system-docs run start --host 0.0.0.0",
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docu:serve script was removed from package.json but is still referenced in the documentation at apps/design-system-docs/README.md line 43. Since the underlying docusaurus serve command is still available in the app's package.json, consider either:

  1. Keeping the docu:serve script wrapper for consistency with other docu:* commands, or
  2. Updating the documentation to directly reference pnpm --filter ./apps/design-system-docs run serve
Suggested change
"docu:start": "pnpm --filter ./apps/design-system-docs run start --host 0.0.0.0",
"docu:start": "pnpm --filter ./apps/design-system-docs run start --host 0.0.0.0",
"docu:serve": "pnpm --filter ./apps/design-system-docs run serve",

Copilot uses AI. Check for mistakes.
Comment on lines +72 to 74
"ghcr.io/devcontainers/features/node:1": {
"version": "22.12.0"
}
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js feature is being added with version 22.12.0, but the base image already specifies typescript-node:22-bullseye which includes Node.js 22. This creates redundancy and potential version conflicts. The Node feature will install a second Node.js version on top of the one already in the base image.

Consider removing the Node feature from the features section since the base image already provides Node.js 22, or use a more minimal base image if you want the features approach. The current setup is redundant and could lead to confusion about which Node.js version is being used.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants