feat: new icons Horizontal unfold more + Horizontal unfold less #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomfrida
requested review from
Chibuzor-Nwemambu,
millus,
torleifhalseth and
vnys
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new horizontal unfold icons to the EDS icon library and updates two existing icons with corrected SVG paths. Additionally, it clarifies the README to explicitly state that edit access to the Assets file in Figma is required to run the scripts.
- Added
unfold_more_horizontalandunfold_less_horizontalicons - Updated
aerial_droneandplayicons with corrected SVG paths - Enhanced documentation to prevent confusion about Figma access requirements
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/figma-broker/README.md | Added important notice about required Figma edit access |
| packages/eds-icons/src/data.ts | Added two new horizontal unfold icons and updated SVG paths for aerial_drone and play icons |
| assets/icons/system-icons/map-transportation/aerial_drone.svg | Updated SVG with corrected path data |
| assets/icons/system-icons/av/play.svg | Updated SVG with corrected path data |
| assets/icons/system-icons/arrows/unfold_more_horizontal.svg | Added new horizontal unfold more icon |
| assets/icons/system-icons/arrows/unfold_less_horizontal.svg | Added new horizontal unfold less icon |
Uppercase Co-authored-by: Copilot <[email protected]>
pomfrida
force-pushed
the
chore/release-new-icons
branch
from
0f7c4b1 to
aad49a5
Compare
Collaborator
Author
pomfrida
changed the title
Collaborator
Author
|
Experiment icon won't show up so merging without them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2388
some other icon updates from figma as well (minor pixel adjustments)
also clarifying the figma broker readme to avoid future frustration