Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open pdfs and external links in a new tab #2790

Open
meols opened this issue Feb 3, 2025 · 4 comments · May be fixed by #2830
Open

Open pdfs and external links in a new tab #2790

meols opened this issue Feb 3, 2025 · 4 comments · May be fixed by #2830
Assignees
@VarunVAshrit

Comments

@meols
Copy link
Collaborator

meols commented Feb 3, 2025 •
edited
Loading

No description provided.

@meols meols changed the title Open pdfs and external links in anew tab Open pdfs and external links in a new tab Feb 3, 2025
@VarunVAshrit VarunVAshrit self-assigned this Feb 10, 2025
VarunVAshrit added a commit that referenced this issue Feb 12, 2025
@VarunVAshrit
✨ Open pdfs and external links in a new tab #2790
87bff6e
@VarunVAshrit VarunVAshrit linked a pull request Feb 12, 2025 that will close this issue
✨ Open pdfs and external links in a new tab #2790 #2830
Open
@VarunVAshrit
Copy link
Collaborator

Hello @meols . As requested the PDFs and external links are opening in a new tab. You can test it here.
https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/news/varuns-test-news

@meols
Copy link
Collaborator Author

meols commented Feb 17, 2025

Thanks @VarunVAshrit - could you please also do the same for links in the footer. Otherwise it looks good.

@VarunVAshrit
Copy link
Collaborator

Hey @meols . Should all the external links which are there in footer should open in a new tab?

@meols
Copy link
Collaborator Author

meols commented Feb 17, 2025 •
edited
Loading

Hi @VarunVAshrit - yes, I think all external links should behave the same way, and open in a new tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VarunVAshrit VarunVAshrit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Open pdfs and external links in a new tab #2790 equinor/energyvision
2 participants
@meols @VarunVAshrit