Skip to content

Conversation

@Blunde1
Copy link
Contributor

@Blunde1 Blunde1 commented Dec 27, 2023

Showcases how to resolve equinor/ert#6599
I think the case for LASSO is well argued for there. Unfortunately I do not know of any reference papers doing this.
The case for LASSO can be seen e.g. from

  • Presentation at EnKF: chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://ncda-fs.web.norce.cloud/WS2023/raanes.pdf
    • EnKF = Monte Carlo + LLS.
  • Transport methods: https://arxiv.org/pdf/2210.17000.pdf
    • We really do want to fit a multivariate Gaussian
  • When doing statistical fitting (fit multivariate Gaussian) we must control the degrees of freedom
    • LLS is inferior to LASSO (and others, e.g. RIDGE), when we are not in the asymptotic case. Model selection as part of the objective, etc.

Thus it makes sense to improve upon EnKF and ES ++ by doing Monte Carlo + LASSO (or Ridge or similar).

@Blunde1 Blunde1 marked this pull request as draft December 27, 2023 12:11
@Blunde1 Blunde1 self-assigned this Dec 28, 2023
@Blunde1 Blunde1 marked this pull request as ready for review January 3, 2024 11:46
@Blunde1
Copy link
Contributor Author

Blunde1 commented Jan 3, 2024

The docs build is failing, I guess because I import graphite-maps? Will copy the imported linear_l1_regression function so that we avoid the import.

@tommyod
Copy link
Collaborator

tommyod commented Jan 3, 2024

Not sure why it fails now. I see no error message... Try running locally

sphinx-build -c docs/source/ -b html docs/source/ docs/build/html -W

@Blunde1
Copy link
Contributor Author

Blunde1 commented Jan 3, 2024

Not sure why it fails now. I see no error message... Try running locally

sphinx-build -c docs/source/ -b html docs/source/ docs/build/html -W

I see I need Java for the docs? (pandoc) Is there no way around this?

From checking the CI I see

Warning, treated as error:
/home/runner/work/iterative_ensemble_smoother/iterative_ensemble_smoother/docs/source/LinearRegression.ipynb:Executing notebook failed: CellExecutionError [mystnb.exec]

perhaps I import or use something in the notebook that is not part of the pip install .[doc] requirements?
Edit: perhaps sklearn

@Blunde1 Blunde1 requested a review from tommyod January 3, 2024 12:44
Copy link
Collaborator

@tommyod tommyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

### Gaussian conditional marginal

The joint KLD is a natural objective to evaluate model performance on.
However, multiple (Kalman) ensemble methods only produce an estiamte $K$ either explicit or explicit,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, multiple (Kalman) ensemble methods only produce an estiamte $K$ either explicit or explicit,
However, multiple (Kalman) ensemble methods only produce an estimate $K$ either explicit or implicit,

Not sure I understand this sentence.
Do you mean that several different ensemble methods only produce an estimate of $K$ without specifying covariance structure?
What do you mean by explicit / implicit?

Blunde1 and others added 5 commits January 22, 2024 12:21
Co-authored-by: Feda Curic <[email protected]>
Co-authored-by: Feda Curic <[email protected]>
Co-authored-by: Feda Curic <[email protected]>
Co-authored-by: Feda Curic <[email protected]>
Co-authored-by: Feda Curic <[email protected]>
@eivindjahren eivindjahren added christmas-review Issues and PRs for Christmas review and removed christmas-review Issues and PRs for Christmas review labels Dec 13, 2024
@oyvindeide oyvindeide removed the status in SCOUT Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Regularize linear regression using LASSO (without structure)

4 participants