New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate keys into the temp folder rather than the current directory #2

Open

eritbh opened this issue Jan 11, 2022 · 0 comments

Labels

enhancement identity creation

Owner

eritbh commented Jan 11, 2022

Also probably split the key creation logic into its own function in common.sh and just keep the high-level logic in op-create-identity

1password-ssh-utils/op-create-identity

Lines 101 to 105 in 9e828e9

    
           # TODO: generate this somewhere it won't be written to disk (use temp dir?) 
        
           # TODO: can we read the new keys into variables here and immediately delete 
        
           #       the file to avoid having to set another variable to remember to 
        
           #       delete it later? 
        
           echo "Generating new keypair..."

The text was updated successfully, but these errors were encountered:

eritbh added enhancement identity creation labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment