Tweak Common Test error output to include source filename?

[essen]

Is your feature request related to a problem? Please describe.
I am defining problem matchers for Erlang (see additional context) and noticed that Eunit prints the file name where the error occurred but Common Test does not. Having the file name enables GitHub to pinpoint errors directly on the PR as a line comment.

Describe the solution you'd like
I am thinking of adding the file name to the formatting for these clauses: https://github.com/erlang/otp/blob/master/lib/common_test/src/ct_framework.erl#L1013-L1034

Describe alternatives you've considered
A CT hook printing raw matcher info.

Additional context
erlef/setup-beam#390

Problem matchers add annotations to CI runs (on the summary page and on individual job pages) and to PRs (on the line/number and if available column the error/warning happened). In short they allow knowing what error occurred without having to go through the CI logs.

I started one that does erlc, dialyzer, ct, eunit. Tested it on my projects for now but plan is to have them for RabbitMQ as well.

[essen]

I figured that we lose the source file information from the exception stacktrace here: https://github.com/erlang/otp/blob/master/lib/common_test/src/test_server.erl#L1826-L1827

Changing that to return the full location (with filename) would likely be a pretty big change.

[IngelaAndin]

@essen Do I understand you correctly if your proposal is to add something to the three clauses you mentioned instead of changing the return value in the place where it was lost, and may be a big change? I am afraid that common_test involves a lot of legacy and or ability to prioritize it at the moment is low. But if you are interested in making a proof of concept PR that is not gigantic we could have time to make an assessment. Otherwise I am afraid this might just end up in the whish list for quite some time.

[essen]

Yeah unfortunately to do it the same way Eunit does it, which is take the file name from the exception trace, it would be a big change and it's likely to cause new bugs.

So I'm thinking of modifying the code around the clauses. There we have the LastMod variable, we can look in LastMod:module_info(compile) for the source file.

From there I just need to figure out how to go from "/home/essen/ninenines/cowboy/src/cowboy.erl" to "src/cowboy.erl" (perhaps matching out file:get_cwd() from the start of the filename, and what to do about "/build/erlang/src/otp/lib/stdlib/src/gen_server.erl" (maybe don't print the filename if it doesn't exist).

I'll try to get something working soon-ish.

[essen]

I have added a PoC at #10269