-
Notifications
You must be signed in to change notification settings - Fork 436
Prometheus quantile summaries #4588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4588 +/- ##
==========================================
+ Coverage 85.95% 85.99% +0.04%
==========================================
Files 565 565
Lines 33930 33927 -3
==========================================
+ Hits 29166 29177 +11
+ Misses 4764 4750 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
small_tests_27 / small_tests / 491dfe8 elasticsearch_and_cassandra_28 / elasticsearch_and_cassandra_mnesia / 491dfe8 small_tests_28 / small_tests / 491dfe8 small_tests_28_arm64 / small_tests / 491dfe8 ldap_mnesia_27 / ldap_mnesia / 491dfe8 ldap_mnesia_28 / ldap_mnesia / 491dfe8 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 491dfe8 graphql_server_SUITE:admin_cli:clustering_tests:join_successful{error,{#{what => invalid_response_code,expected_type => ok,
response_code => {exit_status,1}},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,258}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,241}]},
{graphql_server_SUITE,join_successful,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,153}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}internal_mnesia_28 / internal_mnesia / 491dfe8 dynamic_domains_mysql_redis_28 / mysql_redis / 491dfe8 dynamic_domains_pgsql_mnesia_28 / pgsql_mnesia / 491dfe8 pgsql_cets_28 / pgsql_cets / 491dfe8 mysql_redis_28 / mysql_redis / 491dfe8 dynamic_domains_mssql_mnesia_28 / odbc_mssql_mnesia / 491dfe8 pgsql_mnesia_28 / pgsql_mnesia / 491dfe8 cockroachdb_cets_28 / cockroachdb_cets / 491dfe8 pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_send_last_published_item_no_items_test_3705@localhost/res1">>,
escalus_tcp,<0.115938.0>,
[{event_manager,<0.115935.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3705">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.115935.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3705">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_send_last_published_item_no_items_test_3705">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,fun escalus_auth:auth_plain/2},
{wspath,undefined},
{username,
<<"alicE_send_last_published_item_no_items_test_3705">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"f5eb6764e5afa10a">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_and_c...pubsub_SUITE:tree+last_item_cache:send_last_published_item_no_items_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alice_send_last_published_item_no_items_test_3760@localhost/res1">>,
escalus_tcp,<0.117222.0>,
[{event_manager,<0.117219.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3760">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.117219.0>},
{server,<<"localhost">>},
{username,
<<"alicE_send_last_published_item_no_items_test_3760">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alice_send_last_published_item_no_items_test_3760">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,fun escalus_auth:auth_plain/2},
{wspath,undefined},
{username,
<<"alicE_send_last_published_item_no_items_test_3760">>},
{server,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"a753229358e66438">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_and_c...pgsql_mnesia_27 / pgsql_mnesia / 491dfe8 mssql_mnesia_28 / odbc_mssql_mnesia / 491dfe8 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 491dfe8 |
This PR replaces
prometheus_histogramwithprometheus_quantile_summarythat uses DDSketch algorithm for maintaining pre-defined quantiles with relative-error guarantees.